[PATCH 1/4] drm/amdgpu: use proper DC check in amdgpu_display_supported_domains()

Christian König ckoenig.leichtzumerken at gmail.com
Thu Sep 29 13:30:11 UTC 2022


Feel free to add my acked-by, but that's really not my field of expertise.

Christian.

Am 29.09.22 um 15:15 schrieb Alex Deucher:
> Ping on this series?
>
> Alex
>
> On Thu, Sep 8, 2022 at 10:39 AM Alex Deucher <alexander.deucher at amd.com> wrote:
>> amdgpu_device_asic_has_dc_support() just checks the asic itself.
>> amdgpu_device_has_dc_support() is a runtime check which not
>> only checks the asic, but also other things in the driver
>> like whether virtual display is enabled.  We want the latter
>> here.
>>
>> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
>> ---
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
>> index c20922a5af9f..b0fa5d065d50 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
>> @@ -514,7 +514,7 @@ uint32_t amdgpu_display_supported_domains(struct amdgpu_device *adev,
>>           */
>>          if ((bo_flags & AMDGPU_GEM_CREATE_CPU_GTT_USWC) &&
>>              amdgpu_bo_support_uswc(bo_flags) &&
>> -           amdgpu_device_asic_has_dc_support(adev->asic_type) &&
>> +           amdgpu_device_has_dc_support(adev) &&
>>              adev->mode_info.gpu_vm_support)
>>                  domain |= AMDGPU_GEM_DOMAIN_GTT;
>>   #endif
>> --
>> 2.37.2
>>



More information about the amd-gfx mailing list