[PATCH] drm/amd/display: disable psr whenever applicable

[Harry Wentland]

+Leo

On 9/30/22 06:27, Shirish S wrote:
> [Why]
> psr feature continues to be enabled for non capable links.
> 

Do you have more info on what issues you're seeing with this? 

> [How]
> disable the feature on links that are not capable of the same.
> 
> Signed-off-by: Shirish S <shirish.s at amd.com>
> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
> index 8ca10ab3dfc1..f73af028f312 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
> @@ -60,11 +60,17 @@ static bool link_supports_psrsu(struct dc_link *link)
>   */
>  void amdgpu_dm_set_psr_caps(struct dc_link *link)
>  {
> -	if (!(link->connector_signal & SIGNAL_TYPE_EDP))
> +	if (!(link->connector_signal & SIGNAL_TYPE_EDP)) {
> +		DRM_ERROR("Disabling PSR as connector is not eDP\n")

I don't think we should log an error here.

> +		link->psr_settings.psr_feature_enabled = false;
>  		return;
> +	}
>  
> -	if (link->type == dc_connection_none)
> +	if (link->type == dc_connection_none) {
> +		DRM_ERROR("Disabling PSR as eDP connection type is invalid\n")

Same here, this doesn't warrant an error log.

Harry

> +		link->psr_settings.psr_feature_enabled = false;
>  		return;
> +	}
>  
>  	if (link->dpcd_caps.psr_info.psr_version == 0) {
>  		link->psr_settings.psr_version = DC_PSR_VERSION_UNSUPPORTED;