[bug report] drm/amd/display: Use per pipe P-State force for FPO

Dan Carpenter error27 at gmail.com
Tue Apr 4 06:50:07 UTC 2023


Hello Alvin Lee,

This is a semi-automatic email about new static checker warnings.

The patch 4ed793083afc: "drm/amd/display: Use per pipe P-State force 
for FPO" from Mar 15, 2023, leads to the following Smatch complaint:

    drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_hwseq.c:2009 dcn20_post_unlock_program_front_end()
    error: we previously assumed 'hwseq' could be null (see line 2003)

drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_hwseq.c
  2002		 */
  2003		if (hwseq && hwseq->funcs.update_force_pstate)
                    ^^^^^
The patch adds this NULL check but hopefully it can be deleted.
Otherwise we are screwed.


  2004			dc->hwseq->funcs.update_force_pstate(dc, context);
  2005	
  2006		/* Only program the MALL registers after all the main and phantom pipes
  2007		 * are done programming.
  2008		 */
  2009		if (hwseq->funcs.program_mall_pipe_config)
  2010			hwseq->funcs.program_mall_pipe_config(dc, context);
  2011	

regards,
dan carpenter


More information about the amd-gfx mailing list