[PATCH] drm/amd/amdgpu: Fix trivial style errors

Christian König christian.koenig at amd.com
Wed Apr 5 10:27:50 UTC 2023


Am 05.04.23 um 06:19 schrieb Srinivasan Shanmugam:
> Fix coding style errors reported by checkpatch, specifically:
>
> ERROR: space prohibited before that ',' (ctx:WxV)
> +module_param_named(job_hang_limit, amdgpu_job_hang_limit, int ,0444);
>                                                                 ^
>
> ERROR: space required after that ',' (ctx:WxV)
> +module_param_named(job_hang_limit, amdgpu_job_hang_limit, int ,0444);

Since we don't do resubmission any more this whole parameter can 
probably be removed all together.

Christian.

>
> This patch gets rid of all above type of  "ERROR" messages in
> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c:
>
> Cc: Christian König <christian.koenig at amd.com>
> Cc: Alex Deucher <alexander.deucher at amd.com>
> Cc: Mario Limonciello <mario.limonciello at amd.com>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam at amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index e652ffb2c68e..d2af86c2af2b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -526,7 +526,7 @@ module_param_named(virtual_display, amdgpu_virtual_display, charp, 0444);
>    * Set how much time allow a job hang and not drop it. The default is 0.
>    */
>   MODULE_PARM_DESC(job_hang_limit, "how much time allow a job hang and not drop it (default 0)");
> -module_param_named(job_hang_limit, amdgpu_job_hang_limit, int ,0444);
> +module_param_named(job_hang_limit, amdgpu_job_hang_limit, int, 0444);
>   
>   /**
>    * DOC: lbpw (int)



More information about the amd-gfx mailing list