[PATCH v6 0/2] Send message to PMFW when SMT changes

Limonciello, Mario mario.limonciello at amd.com
Fri Apr 7 13:41:48 UTC 2023


On 4/7/2023 00:38, Wenyou Yang wrote:
> When the SMT changes on the fly, send the message to the PMFW
> to notify the SMT status changed.
> 
> Changes in v6
> 1./ Update last_smt_active only when the return from
> smu_set_cpu_smt_enable() successfully.
> 2./ Use smu->adev->pm.fw_version to check smu version, if it is not
> assigned, get the smu version and assigned it.
> 3./ Remove the redundant error message print.
> 
> Changes in v5
> 1./ Add a new vangogh_fini_smc_tables() to accommodate the timer fini
> and smu_v11_0_fini_smc_tables().
> 2./ Move the version check of SMU version before initializing the timer.
> 
> Changes in v4
> 1./ Since we didn't find a good solution to handle the case that
> manually offlining all the SMT siblings using
> /sys/devices/system/cpu/cpu*/online to disable or enable SMT.
> Come up with a new solution, add a timer to poll the SMT state
> periodically, if finding that the SMT state is changed, it invokes
> the interface to notify the PMFW.
> 2./ Move the generic code to smu_cmn.c.
> 3./ Add PMFW version check for this feature.
> 
> Changes in v3
> 1./ Because it is only required for Vangogh, move registering notifier
> to vangogh_ppt.c, then remove the patch 2, and the number of patches
> decreased to 2.
> 
> Changes in v2:
> 1/. Embed the smt notifer callback into "struct smu_context" structure.
> 2/. Correct the PPSMC_Message_Count value.
> 3/. Improve several code styles and others.
> 
> Wenyou Yang (2):
>    drm/amd/pm: Add support to check SMT state periodically
>    drm/amd/pm/vangogh: Send SMT enable message to PMFW
> 
>   drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h |  8 ++++
>   .../pm/swsmu/inc/pmfw_if/smu_v11_5_ppsmc.h    |  3 +-
>   drivers/gpu/drm/amd/pm/swsmu/inc/smu_types.h  |  3 +-
>   .../gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c  | 32 +++++++++++++-
>   drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c        | 44 +++++++++++++++++++
>   drivers/gpu/drm/amd/pm/swsmu/smu_cmn.h        |  5 +++
>   6 files changed, 92 insertions(+), 3 deletions(-)
> 

For series:

Reviewed-by: Mario Limonciello <mario.limonciello at amd.com>


More information about the amd-gfx mailing list