[PATCH Review V2 2/2] drm/amdgpu: correct ras enabled flag

[Yang, Stanley]

[AMD Official Use Only - General]

Thanks, It's a typo, I have fixed it before be merged.

Regards,
Stanley
> -----Original Message-----
> From: Lazar, Lijo <Lijo.Lazar at amd.com>
> Sent: Tuesday, April 11, 2023 6:08 PM
> To: Yang, Stanley <Stanley.Yang at amd.com>; amd-gfx at lists.freedesktop.org;
> Zhang, Hawking <Hawking.Zhang at amd.com>; Zhou1, Tao
> <Tao.Zhou1 at amd.com>; Chen, Guchun <Guchun.Chen at amd.com>
> Cc: Yang, Stanley <Stanley.Yang at amd.com>
> Subject: RE: [PATCH Review V2 2/2] drm/amdgpu: correct ras enabled flag
> 
> [AMD Official Use Only - General]
> 
> >  if (adev->gmc.xmgi.
> 
> This looks like a typo. Should be gmc.xgmi
> 
> Thanks,
> Lijo
> 
> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of
> Stanley.Yang
> Sent: Tuesday, April 11, 2023 3:03 PM
> To: amd-gfx at lists.freedesktop.org; Zhang, Hawking
> <Hawking.Zhang at amd.com>; Zhou1, Tao <Tao.Zhou1 at amd.com>; Chen,
> Guchun <Guchun.Chen at amd.com>
> Cc: Yang, Stanley <Stanley.Yang at amd.com>
> Subject: [PATCH Review V2 2/2] drm/amdgpu: correct ras enabled flag
> 
> XGMI RAS should be according to the gmc xgmi physical nodes number,
> XGMI RAS should not be enabled if xgmi num_physical_nodes is zero.
> 
> Change-Id: Idf3600b30584b10b528e7237d103d84d5097b7e0
> Signed-off-by: Stanley.Yang <Stanley.Yang at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> index 4069bce9479f..c2c4d978896c 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> @@ -2430,6 +2430,13 @@ static void amdgpu_ras_check_supported(struct
> amdgpu_device *adev)
>  			else
>  				adev->ras_hw_enabled &= ~(1 <<
> AMDGPU_RAS_BLOCK__VCN |
>  							1 <<
> AMDGPU_RAS_BLOCK__JPEG);
> +
> +			/*
> +			 * XGMI RAS is not supported if xgmi num physical
> nodes
> +			 * is zero
> +			 */
> +			if (adev->gmc.xmgi.num_physical_nodes == 0)
> +				adev->ras_hw_enabled &= ~(1 <<
> AMDGPU_RAS_BLOCK__XGMI_WAFL);
>  		} else {
>  			dev_info(adev->dev, "SRAM ECC is not
> presented.\n");
>  		}
> --
> 2.17.1