[PATCH v2] drm/amd/display: Improvise error handling for DP sink power states
Aurabindo Pillai
aurabindo.pillai at amd.com
Thu Apr 13 18:10:39 UTC 2023
Reviewed-by: Aurabindo Pillai <aurabindo.pillai at amd.com>
On 4/13/23 14:02, Srinivasan Shanmugam wrote:
> Log if we fail to setup sink power states.
>
> Cc: Fangzhi Zuo <Jerry.Zuo at amd.com>
> Cc: Aurabindo Pillai <aurabindo.pillai at amd.com>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam at amd.com>
> ---
>
> v2:
>
> - Change DC_LOG_HW_LINK_TRAINING to DC_LOG_DC, as link training related
> code moved to drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_training.c (Aurabindo)
>
>
> .../gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c
> index c840ef17802e..ba98013fecd0 100644
> --- a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c
> +++ b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c
> @@ -1043,6 +1043,9 @@ static enum dc_status wake_up_aux_channel(struct dc_link *link)
> DP_SET_POWER,
> &dpcd_power_state,
> sizeof(dpcd_power_state));
> + if (status < 0)
> + DC_LOG_DC("%s: Failed to power up sink: %s\n", __func__,
> + dpcd_power_state == DP_SET_POWER_D0 ? "D0" : "D3");
> return DC_ERROR_UNEXPECTED;
> }
>
More information about the amd-gfx
mailing list