[PATCH 07/12] drm/amdgpu/gfx11: drop unused variable

Christian König ckoenig.leichtzumerken at gmail.com
Fri Apr 28 08:59:40 UTC 2023


Am 27.04.23 um 17:27 schrieb Alex Deucher:
> Just check the return value directly.
>
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>

Reviewed-by: Christian König <christian.koenig at amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
> index d36d365cb582..256014a8c824 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
> @@ -4373,7 +4373,6 @@ static int gfx_v11_0_hw_init(void *handle)
>   static int gfx_v11_0_hw_fini(void *handle)
>   {
>   	struct amdgpu_device *adev = (struct amdgpu_device *)handle;
> -	int r;
>   
>   	amdgpu_irq_put(adev, &adev->gfx.cp_ecc_error_irq, 0);
>   	amdgpu_irq_put(adev, &adev->gfx.priv_reg_irq, 0);
> @@ -4381,8 +4380,7 @@ static int gfx_v11_0_hw_fini(void *handle)
>   
>   	if (!adev->no_hw_access) {
>   		if (amdgpu_async_gfx_ring) {
> -			r = amdgpu_gfx_disable_kgq(adev, 0);
> -			if (r)
> +			if (amdgpu_gfx_disable_kgq(adev, 0))
>   				DRM_ERROR("KGQ disable failed\n");
>   		}
>   



More information about the amd-gfx mailing list