[PATCH] drm/radeon: Remove the references of radeon_gem_ pread & pwrite ioctls

[Alex Deucher]

On Thu, Jul 27, 2023 at 9:48 AM Srinivasan Shanmugam
<srinivasan.shanmugam at amd.com> wrote:
>
> Removing the functions of pread & pwrite & IOCTL defines, as their
> existence allows an authorized client to spam the system logs.
>
> 'Fixes: 6f9e0e87b71f ("drm/radeon: Fix ENOSYS with better fitting error codes in radeon_gem.c")'
> Suggested-by: Christian König <christian.koenig at amd.com>
> Cc: Christian König <christian.koenig at amd.com>
> Cc: Alex Deucher <alexander.deucher at amd.com>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam at amd.com>

Acked-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/radeon/radeon.h     |  4 ----
>  drivers/gpu/drm/radeon/radeon_drv.c |  2 --
>  drivers/gpu/drm/radeon/radeon_gem.c | 16 ----------------
>  3 files changed, 22 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon.h b/drivers/gpu/drm/radeon/radeon.h
> index b1c3871f2a67..102f7e25faa6 100644
> --- a/drivers/gpu/drm/radeon/radeon.h
> +++ b/drivers/gpu/drm/radeon/radeon.h
> @@ -2254,10 +2254,6 @@ int radeon_gem_pin_ioctl(struct drm_device *dev, void *data,
>                          struct drm_file *file_priv);
>  int radeon_gem_unpin_ioctl(struct drm_device *dev, void *data,
>                            struct drm_file *file_priv);
> -int radeon_gem_pwrite_ioctl(struct drm_device *dev, void *data,
> -                           struct drm_file *file_priv);
> -int radeon_gem_pread_ioctl(struct drm_device *dev, void *data,
> -                          struct drm_file *file_priv);
>  int radeon_gem_set_domain_ioctl(struct drm_device *dev, void *data,
>                                 struct drm_file *filp);
>  int radeon_gem_mmap_ioctl(struct drm_device *dev, void *data,
> diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c
> index aa02697e5ea3..7fea9edafa67 100644
> --- a/drivers/gpu/drm/radeon/radeon_drv.c
> +++ b/drivers/gpu/drm/radeon/radeon_drv.c
> @@ -555,8 +555,6 @@ static const struct drm_ioctl_desc radeon_ioctls_kms[] = {
>         DRM_IOCTL_DEF_DRV(RADEON_GEM_CREATE, radeon_gem_create_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),
>         DRM_IOCTL_DEF_DRV(RADEON_GEM_MMAP, radeon_gem_mmap_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),
>         DRM_IOCTL_DEF_DRV(RADEON_GEM_SET_DOMAIN, radeon_gem_set_domain_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),
> -       DRM_IOCTL_DEF_DRV(RADEON_GEM_PREAD, radeon_gem_pread_ioctl, DRM_AUTH),
> -       DRM_IOCTL_DEF_DRV(RADEON_GEM_PWRITE, radeon_gem_pwrite_ioctl, DRM_AUTH),
>         DRM_IOCTL_DEF_DRV(RADEON_GEM_WAIT_IDLE, radeon_gem_wait_idle_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),
>         DRM_IOCTL_DEF_DRV(RADEON_CS, radeon_cs_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),
>         DRM_IOCTL_DEF_DRV(RADEON_INFO, radeon_info_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),
> diff --git a/drivers/gpu/drm/radeon/radeon_gem.c b/drivers/gpu/drm/radeon/radeon_gem.c
> index 358d19242f4b..3fec3acdaf28 100644
> --- a/drivers/gpu/drm/radeon/radeon_gem.c
> +++ b/drivers/gpu/drm/radeon/radeon_gem.c
> @@ -311,22 +311,6 @@ int radeon_gem_info_ioctl(struct drm_device *dev, void *data,
>         return 0;
>  }
>
> -int radeon_gem_pread_ioctl(struct drm_device *dev, void *data,
> -                          struct drm_file *filp)
> -{
> -       /* TODO: implement */
> -       DRM_ERROR("unimplemented %s\n", __func__);
> -       return -EOPNOTSUPP;
> -}
> -
> -int radeon_gem_pwrite_ioctl(struct drm_device *dev, void *data,
> -                           struct drm_file *filp)
> -{
> -       /* TODO: implement */
> -       DRM_ERROR("unimplemented %s\n", __func__);
> -       return -EOPNOTSUPP;
> -}
> -
>  int radeon_gem_create_ioctl(struct drm_device *dev, void *data,
>                             struct drm_file *filp)
>  {
> --
> 2.25.1
>