[PATCH] drm/amdkfd: Add missing tba_hi programming on aldebaran

Deucher, Alexander Alexander.Deucher at amd.com
Wed Aug 9 21:28:40 UTC 2023


[AMD Official Use Only - General]

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>
________________________________
From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> on behalf of Jay Cornwall <jay.cornwall at amd.com>
Sent: Wednesday, August 9, 2023 5:26 PM
To: amd-gfx at lists.freedesktop.org <amd-gfx at lists.freedesktop.org>
Cc: Cornwall, Jay <Jay.Cornwall at amd.com>; Kasiviswanathan, Harish <Harish.Kasiviswanathan at amd.com>
Subject: [PATCH] drm/amdkfd: Add missing tba_hi programming on aldebaran

Previously asymptomatic because high 32 bits were zero.

Fixes: 615222cfed20 ("drm/amdkfd: Relocate TBA/TMA to opposite side of VM hole")
Signed-off-by: Jay Cornwall <jay.cornwall at amd.com>
---
 drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c b/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c
index 8fda16e6fee6..8ce6f5200905 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c
@@ -121,6 +121,7 @@ static int pm_map_process_aldebaran(struct packet_manager *pm,
         packet->sh_mem_bases = qpd->sh_mem_bases;
         if (qpd->tba_addr) {
                 packet->sq_shader_tba_lo = lower_32_bits(qpd->tba_addr >> 8);
+               packet->sq_shader_tba_hi = upper_32_bits(qpd->tba_addr >> 8);
                 packet->sq_shader_tma_lo = lower_32_bits(qpd->tma_addr >> 8);
                 packet->sq_shader_tma_hi = upper_32_bits(qpd->tma_addr >> 8);
         }
--
2.25.1

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20230809/3fe85097/attachment.htm>


More information about the amd-gfx mailing list