[PATCH V8 1/9] drivers core: Add support for Wifi band RF mitigations

[Quan, Evan]

[AMD Official Use Only - General]



> -----Original Message-----
> From: Randy Dunlap <rdunlap at infradead.org>
> Sent: Thursday, August 10, 2023 11:41 PM
> To: Quan, Evan <Evan.Quan at amd.com>; rafael at kernel.org; lenb at kernel.org;
> Deucher, Alexander <Alexander.Deucher at amd.com>; Koenig, Christian
> <Christian.Koenig at amd.com>; Pan, Xinhui <Xinhui.Pan at amd.com>;
> airlied at gmail.com; daniel at ffwll.ch; johannes at sipsolutions.net;
> davem at davemloft.net; edumazet at google.com; kuba at kernel.org;
> pabeni at redhat.com; Limonciello, Mario <Mario.Limonciello at amd.com>;
> mdaenzer at redhat.com; maarten.lankhorst at linux.intel.com;
> tzimmermann at suse.de; hdegoede at redhat.com; jingyuwang_vip at 163.com;
> Lazar, Lijo <Lijo.Lazar at amd.com>; jim.cromie at gmail.com;
> bellosilicio at gmail.com; andrealmeid at igalia.com; trix at redhat.com;
> jsg at jsg.id.au; arnd at arndb.de; andrew at lunn.ch
> Cc: linux-kernel at vger.kernel.org; linux-acpi at vger.kernel.org; amd-
> gfx at lists.freedesktop.org; dri-devel at lists.freedesktop.org; linux-
> wireless at vger.kernel.org; netdev at vger.kernel.org
> Subject: Re: [PATCH V8 1/9] drivers core: Add support for Wifi band RF
> mitigations
> 
> 
> 
> On 8/10/23 00:37, Evan Quan wrote:
> > diff --git a/Documentation/admin-guide/kernel-parameters.txt
> > b/Documentation/admin-guide/kernel-parameters.txt
> > index a1457995fd41..21f73a0bbd0b 100644
> > --- a/Documentation/admin-guide/kernel-parameters.txt
> > +++ b/Documentation/admin-guide/kernel-parameters.txt
> > @@ -7152,3 +7152,12 @@
> >  				xmon commands.
> >  			off	xmon is disabled.
> >
> > +	wbrf=		[KNL]
> > +			Format: { on | auto | off }
> > +			Controls if WBRF features should be enabled or
> disabled
> > +			forcely. Default is auto.
> 
> "forcely" is not a word. "forcedly" is a word, but it's not used very much AFAIK.
> I would probably write "Controls if WBRF features should be forced on or off."
Yeah, that sounds better. Will update this as suggested.

Evan
> 
> > +			on	Force enable the WBRF features.
> > +			auto	Up to the system to do proper checks to
> > +				determine the WBRF features should be
> enabled
> > +				or not.
> > +			off	Force disable the WBRF features.
> 
> --
> ~Randy