[PATCH] drm/amdgpu: Fix kcalloc over kzalloc in 'gmc_v9_0_init_mem_ranges'

Lazar, Lijo lijo.lazar at amd.com
Fri Aug 18 07:45:31 UTC 2023



On 8/18/2023 12:15 PM, Srinivasan Shanmugam wrote:
> Replace kzalloc(n * sizeof(...), ...) with kcalloc(n, sizeof(...), ...)
> since kcalloc is the preferred API in case of allocating with multiply.
> 
> Fixes the below:
> 
> WARNING: Prefer kcalloc over kzalloc with multiply
> 
> Cc: Guchun Chen <guchun.chen at amd.com>
> Cc: Christian König <christian.koenig at amd.com>
> Cc: Alex Deucher <alexander.deucher at amd.com>
> Cc: "Pan, Xinhui" <Xinhui.Pan at amd.com>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam at amd.com>

Reviewed-by: Lijo Lazar <lijo.lazar at amd.com>

Thanks,
Lijo

> ---
>   drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> index f9a5a2c0573e..0673cda547bb 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> @@ -1972,10 +1972,9 @@ static int gmc_v9_0_init_mem_ranges(struct amdgpu_device *adev)
>   {
>   	bool valid;
>   
> -	adev->gmc.mem_partitions = kzalloc(
> -		MAX_MEM_RANGES * sizeof(struct amdgpu_mem_partition_info),
> -		GFP_KERNEL);
> -
> +	adev->gmc.mem_partitions = kcalloc(MAX_MEM_RANGES,
> +					   sizeof(struct amdgpu_mem_partition_info),
> +					   GFP_KERNEL);
>   	if (!adev->gmc.mem_partitions)
>   		return -ENOMEM;
>   


More information about the amd-gfx mailing list