[PATCH 00/16] DC Patches August 18, 2023

Wheeler, Daniel Daniel.Wheeler at amd.com
Mon Aug 21 13:28:39 UTC 2023


[Public]

Hi all,

This week this patchset was tested on the following systems:
        * Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U
        * MSI Gaming X Trio RX 6800
        * Gigabyte Gaming OC RX 7900 XTX

These systems were tested on the following display/connection types:
        * eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U])
        * VGA and DVI (1680x1050 60hz [DP to VGA/DVI, USB-C to VGA/DVI])
        * DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz, 4k 240hz [Includes USB-C to DP/HDMI adapters])
        * Thunderbolt (LG Ultrafine 5k)
        * MST (Startech MST14DP123DP [DP to 3x DP] and 2x 4k 60Hz displays)
        * DSC (with Cable Matters 101075 [DP to 3x DP] with 3x 4k60 displays, and HP Hook G2 with 1 4k60 display)
        * USB 4 (Kensington SD5700T and 1x 4k 60Hz display)
        * PCON (Club3D CAC-1085 and 1x 4k 144Hz display [at 4k 120HZ, as that is the max the adapter supports])

The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to):
        * Changing display configurations and settings
        * Benchmark testing
        * Feature testing (Freesync, etc.)

Automated testing includes (but is not limited to):
        * Script testing (scripts to automate some of the manual checks)
        * IGT testing

The patchset consists of the amd-staging-drm-next branch (Head commit - 06e1ec5a9a88 drm/amd/display: Promote DAL to 3.2.247) with new patches added on top of it.

Tested on Ubuntu 22.04.3, on Wayland and X11, using Gnome for both.

Tested-by: Daniel Wheeler <daniel.wheeler at amd.com>


Thank you,

Dan Wheeler
Sr. Technologist | AMD
SW Display
------------------------------------------------------------------------------------------------------------------
1 Commerce Valley Dr E, Thornhill, ON L3T 7X6
amd.com

-----Original Message-----
From: Wayne Lin <Wayne.Lin at amd.com>
Sent: Wednesday, August 16, 2023 2:07 AM
To: amd-gfx at lists.freedesktop.org
Cc: Wentland, Harry <Harry.Wentland at amd.com>; Li, Sun peng (Leo) <Sunpeng.Li at amd.com>; Lakha, Bhawanpreet <Bhawanpreet.Lakha at amd.com>; Siqueira, Rodrigo <Rodrigo.Siqueira at amd.com>; Pillai, Aurabindo <Aurabindo.Pillai at amd.com>; Zhuo, Qingqing (Lillian) <Qingqing.Zhuo at amd.com>; Li, Roman <Roman.Li at amd.com>; Lin, Wayne <Wayne.Lin at amd.com>; Wang, Chao-kai (Stylon) <Stylon.Wang at amd.com>; Chiu, Solomon <Solomon.Chiu at amd.com>; Kotarac, Pavle <Pavle.Kotarac at amd.com>; Gutierrez, Agustin <Agustin.Gutierrez at amd.com>; Lin, Wayne <Wayne.Lin at amd.com>; Wheeler, Daniel <Daniel.Wheeler at amd.com>
Subject: [PATCH 00/16] DC Patches August 18, 2023

This DC patchset brings improvements in multiple areas. In summary, we have:

- Ensure FS is enabled before sending request to DMUB for FS changes
- Add check for PMFW hard min request complete
- Save addr update in scratch before flip
- Fix static screen detection setting
- Write flip addr to scratch reg for subvp
- set minimum of VBlank_nom
- Correct unit conversion for vstartup
- Roll back unit correction
- Enable runtime register offset init for DCN32 DMUB
- Refactor edp power control
- PQ regamma end point
- PQ tail accuracy
- Blank phantom OTG before enabling
- Expose mall capability

Cc: Daniel Wheeler <daniel.wheeler at amd.com>

---

Alvin Lee (3):
  drm/amd/display: Blank phantom OTG before enabling
  drm/amd/display: Write flip addr to scratch reg for subvp
  drm/amd/display: Save addr update in scratch before flip

Anthony Koo (1):
  drm/amd/display: [FW Promotion] Release 0.0.180.0

Aric Cyr (1):
  drm/amd/display: 3.2.248

Aurabindo Pillai (2):
  drm/amd/display: Expose mall capability
  drm/amd/display: Enable runtime register offset init for DCN32 DMUB

ChunTao Tso (1):
  drm/amd/display: set minimum of VBlank_nom

Ian Chen (1):
  drm/amd/display: Refactor edp power control

Krunoslav Kovac (2):
  drm/amd/display: PQ tail accuracy
  drm/amd/display: PQ regamma end point

Ovidiu Bunea (1):
  drm/amd/display: Roll back unit correction

Reza Amini (1):
  drm/amd/display: Correct unit conversion for vstartup

Samson Tam (2):
  drm/amd/display: add check for PMFW hard min request complete
  drm/amd/display: ensure FS is enabled before sending request to DMUB
    for FS changes

SungHuai Wang (1):
  drm/amd/display: fix static screen detection setting

 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |   5 +
 .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c |  19 +++  .../drm/amd/display/dc/clk_mgr/dcn32/dalsmc.h |  11 +-  .../dc/clk_mgr/dcn32/dcn32_clk_mgr_smu_msg.c  | 154 +++++++++++++++++-
 drivers/gpu/drm/amd/display/dc/core/dc.c      |  71 +++-----
 .../drm/amd/display/dc/core/dc_hw_sequencer.c |  23 +++
 drivers/gpu/drm/amd/display/dc/dc.h           |   6 +-
 drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c  |  11 +-
 drivers/gpu/drm/amd/display/dc/dc_dmub_srv.h  |   1 +
 drivers/gpu/drm/amd/display/dc/dc_stream.h    |   1 -
 .../display/dc/dce110/dce110_hw_sequencer.c   |   2 +-
 .../drm/amd/display/dc/dcn20/dcn20_hwseq.c    |  22 ++-
 .../amd/display/dc/dcn30/dcn30_cm_common.c    | 104 ++++--------
 .../drm/amd/display/dc/dcn30/dcn30_hwseq.c    |  17 ++
 .../drm/amd/display/dc/dcn30/dcn30_hwseq.h    |   2 +
 .../gpu/drm/amd/display/dc/dcn30/dcn30_init.c |   2 +-
 .../gpu/drm/amd/display/dc/dcn30/dcn30_mpc.c  |  17 --
 .../gpu/drm/amd/display/dc/dcn31/dcn31_init.c |   2 +-
 .../drm/amd/display/dc/dcn314/dcn314_hwseq.c  |   3 +-
 .../drm/amd/display/dc/dcn314/dcn314_init.c   |   2 +-
 .../drm/amd/display/dc/dcn32/dcn32_hwseq.c    |  46 ++++++
 .../drm/amd/display/dc/dcn32/dcn32_hwseq.h    |   5 +
 .../gpu/drm/amd/display/dc/dcn32/dcn32_init.c |   3 +-
 .../amd/display/dc/dml/dcn314/dcn314_fpu.c    |  21 ++-
 .../drm/amd/display/dc/dml/dcn32/dcn32_fpu.c  |  18 ++
 .../gpu/drm/amd/display/dc/inc/core_types.h   |   2 +
 .../gpu/drm/amd/display/dc/inc/hw_sequencer.h |  15 +-
 drivers/gpu/drm/amd/display/dc/inc/link.h     |   1 +
 .../gpu/drm/amd/display/dc/link/link_dpms.c   |   9 +-
 .../drm/amd/display/dc/link/link_factory.c    |   1 +
 .../display/dc/link/protocols/link_dp_phy.c   |   3 +-
 .../link/protocols/link_edp_panel_control.c   |  29 ++++
 .../link/protocols/link_edp_panel_control.h   |   1 +
 drivers/gpu/drm/amd/display/dmub/dmub_srv.h   |  21 ++-
 .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h   |   5 -
 .../gpu/drm/amd/display/dmub/src/dmub_dcn32.c |  64 ++++++--  .../gpu/drm/amd/display/dmub/src/dmub_dcn32.h |  17 +-
 .../gpu/drm/amd/display/dmub/src/dmub_srv.c   |  13 ++
 .../amd/display/modules/color/color_gamma.c   | 115 ++++++++++++-
 39 files changed, 674 insertions(+), 190 deletions(-)

--
2.37.3



More information about the amd-gfx mailing list