[PATCH 0/8] A new set of Linux OD interfaces

[Alex Deucher]

On Tue, Aug 15, 2023 at 4:50 AM Evan Quan <evan.quan at amd.com> wrote:
>
> The existing OD interface `pp_od_clk_voltage` is unable to meet the growing
> demands for more OD functionalities. Since the buf used within it comes with
> size limit as one page. With more OD functionalities added, we will hit that
> limit soon.
>
> To better meet the growing demainds, a new set of OD interfaces are designed.
> With this new design, there will be multiple interfaces exposed with each
> representing a single OD functionality. And all those interfaces will be
> arranged in a tree liked hierarchy as below. Meanwhile all functionalities
> for the same component will be arranged under the same directory.

Patches look good to me, but please add kerneldoc for this to
amdgpu_pm.c and make sure it gets picked up in
Documentation/gpu/amdgpu/thermal.rst.

Alex

>
> gpu_od/
> ├── fan_ctrl
>     ├── acoustic_limit_rpm_threshold
>     ├── acoustic_target_rpm_threshold
>     ├── fan_curve
>     ├── fan_minimum_pwm
>     ├── fan_mode
>     ├── fan_target_temperature
> ...
> ...(more to be added)
>
>
> Evan Quan (8):
>   drm/amd/pm: introduce a new set of OD interfaces
>   drm/amdgpu: revise the device initialization sequences
>   drm/amd/pm: add fan mode OD setting support for SMU13
>   drm/amd/pm: add fan temperature/pwm curve OD setting support for SMU13
>   drm/amd/pm: add fan acoustic limit OD setting support for SMU13
>   drm/amd/pm: add fan acoustic target OD setting support for SMU13
>   drm/amd/pm: add fan target temperature OD setting support for SMU13
>   drm/amd/pm: add fan minimum pwm OD setting support for SMU13
>
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c    |  39 +-
>  .../gpu/drm/amd/include/kgd_pp_interface.h    |  14 +-
>  drivers/gpu/drm/amd/pm/amdgpu_pm.c            | 676 +++++++++++++++++-
>  drivers/gpu/drm/amd/pm/inc/amdgpu_dpm.h       |  16 +
>  drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c     |  12 +
>  drivers/gpu/drm/amd/pm/swsmu/inc/smu_types.h  |   6 +
>  .../drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c  | 316 +++++++-
>  .../drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c  | 316 +++++++-
>  8 files changed, 1370 insertions(+), 25 deletions(-)
>
> --
> 2.34.1
>