[PATCH 2/3] drm/amdgpu/sdma5.0: add begin/end_use ring callbacks

Deucher, Alexander Alexander.Deucher at amd.com
Fri Dec 8 22:38:26 UTC 2023


[Public]

> -----Original Message-----
> From: Deucher, Alexander <Alexander.Deucher at amd.com>
> Sent: Friday, December 8, 2023 5:19 PM
> To: amd-gfx at lists.freedesktop.org
> Cc: Deucher, Alexander <Alexander.Deucher at amd.com>
> Subject: [PATCH 2/3] drm/amdgpu/sdma5.0: add begin/end_use ring
> callbacks
>
> Add begin/end_use ring callbacks to disallow GFXOFF when SDMA work is
> submitted and allow it again afterward.
>
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>

This one can probably be dropped.  It's only needed if anyone on navi1x is experiencing a similar issue.

Alex

> ---
>  drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c
> b/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c
> index 5c1bb6d07a76..1a68cd2de522 100644
> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c
> @@ -1790,6 +1790,8 @@ static const struct amdgpu_ring_funcs
> sdma_v5_0_ring_funcs = {
>       .test_ib = sdma_v5_0_ring_test_ib,
>       .insert_nop = sdma_v5_0_ring_insert_nop,
>       .pad_ib = sdma_v5_0_ring_pad_ib,
> +     .begin_use = amdgpu_sdma_ring_begin_use,
> +     .end_use = amdgpu_sdma_ring_end_use,
>       .emit_wreg = sdma_v5_0_ring_emit_wreg,
>       .emit_reg_wait = sdma_v5_0_ring_emit_reg_wait,
>       .emit_reg_write_reg_wait =
> sdma_v5_0_ring_emit_reg_write_reg_wait,
> --
> 2.42.0



More information about the amd-gfx mailing list