[PATCH v2] drm/amd/display: Address function parameter 'context' not described in 'dc_state_rem_all_planes_for_stream' & 'populate_subvp_cmd_drr_info'

[Aurabindo Pillai]

On 2023-12-21 11:28, Srinivasan Shanmugam wrote:
> Fixes the following gcc with W=1:
> 
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_state.c:524: warning: Function parameter or member 'state' not described in 'dc_state_rem_all_planes_for_stream'
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_state.c:524: warning: Excess function parameter 'context' description in 'dc_state_rem_all_planes_for_stream'
> drivers/gpu/drm/amd/amdgpu/../display/dc/dc_dmub_srv.c:540: warning: Function parameter or member 'context' not described in 'populate_subvp_cmd_drr_info'
> 
> Cc: Dillon Varone <dillon.varone at amd.com>
> Cc: Jun Lei <jun.lei at amd.com>
> Cc: Hamza Mahfooz <hamza.mahfooz at amd.com>
> Cc: Aurabindo Pillai <aurabindo.pillai at amd.com>
> Cc: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>
> Cc: Alex Deucher <alexander.deucher at amd.com>
> Cc: Srinath Rao <srinath.rao at amd.com>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam at amd.com>
> ---
>   drivers/gpu/drm/amd/display/dc/core/dc_state.c | 2 +-
>   drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c   | 3 ++-
>   2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_state.c b/drivers/gpu/drm/amd/display/dc/core/dc_state.c
> index dd52cab7ecdf..460a8010c79f 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_state.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_state.c
> @@ -511,7 +511,7 @@ bool dc_state_remove_plane(
>    *
>    * @dc: Current dc state.
>    * @stream: Target stream, which we want to remove the attached plans.
> - * @context: New context.
> + * @state: context from which the planes are to be removed.
>    *
>    * Return:
>    * Return true if DC was able to remove all planes from the target
> diff --git a/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c b/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
> index 1d315f7cdce3..a59b982e99bf 100644
> --- a/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
> +++ b/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
> @@ -519,10 +519,11 @@ void dc_dmub_srv_get_visual_confirm_color_cmd(struct dc *dc, struct pipe_ctx *pi
>   /**
>    * populate_subvp_cmd_drr_info - Helper to populate DRR pipe info for the DMCUB subvp command
>    *
> - * @dc: [in] current dc state
> + * @dc: [in] pointer to dc object
>    * @subvp_pipe: [in] pipe_ctx for the SubVP pipe
>    * @vblank_pipe: [in] pipe_ctx for the DRR pipe
>    * @pipe_data: [in] Pipe data which stores the VBLANK/DRR info
> + * @context: [in] DC state for access to phantom stream
>    *
>    * Populate the DMCUB SubVP command with DRR pipe info. All the information
>    * required for calculating the SubVP + DRR microschedule is populated here.

Reviewed-by: Aurabindo Pillai <aurabindo.pillai at amd.com>