[PATCH 2/2] drm/amd/display: minor cleanup of vm_setup

[Zhang, Hawking]

[AMD Official Use Only - General]

BTW, @Deucher, Alexander gfxhub_v3_0_3/mmhub_v3_0_3 also need similar fixes

Regards,
Hawking

-----Original Message-----
From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of Zhang, Hawking
Sent: Thursday, February 9, 2023 15:13
To: Deucher, Alexander <Alexander.Deucher at amd.com>; amd-gfx at lists.freedesktop.org
Cc: Deucher, Alexander <Alexander.Deucher at amd.com>
Subject: RE: [PATCH 2/2] drm/amd/display: minor cleanup of vm_setup

[AMD Official Use Only - General]

[AMD Official Use Only - General]

Series is

Reviewed-by: Hawking Zhang <Hawking.Zhang at amd.com>

Regards,
Hawking
-----Original Message-----
From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of Alex Deucher
Sent: Thursday, February 9, 2023 12:46
To: amd-gfx at lists.freedesktop.org
Cc: Deucher, Alexander <Alexander.Deucher at amd.com>
Subject: [PATCH 2/2] drm/amd/display: minor cleanup of vm_setup

Use fb_start/end for consistency with gmc code for non- XGMI systems, they are equivalent to vram_start/end.

Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 8ba4a57d8e6f..bf06875e6a01 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -1191,7 +1191,7 @@ static void mmhub_read_system_context(struct amdgpu_device *adev, struct dc_phy_

        /* AGP aperture is disabled */
        if (agp_bot == agp_top) {
-               logical_addr_low  = adev->gmc.vram_start >> 18;
+               logical_addr_low = adev->gmc.fb_start >> 18;
                if (adev->apu_flags & AMD_APU_IS_RAVEN2)
                        /*
                         * Raven2 has a HW issue that it is unable to use the vram which @@ -1201,9 +1201,9 @@ static void mmhub_read_system_context(struct amdgpu_device *adev, struct dc_phy_
                         */
                        logical_addr_high = (adev->gmc.fb_end >> 18) + 0x1;
                else
-                       logical_addr_high = adev->gmc.vram_end >> 18;
+                       logical_addr_high = adev->gmc.fb_end >> 18;
        } else {
-               logical_addr_low  = min(adev->gmc.fb_start, adev->gmc.agp_start) >> 18;
+               logical_addr_low = min(adev->gmc.fb_start,
+adev->gmc.agp_start) >> 18;
                if (adev->apu_flags & AMD_APU_IS_RAVEN2)
                        /*
                         * Raven2 has a HW issue that it is unable to use the vram which
--
2.39.1