[PATCH 0/6] Trivial code cleanup around color resources

Christian König ckoenig.leichtzumerken at gmail.com
Tue Feb 14 12:48:44 UTC 2023


Am 14.02.23 um 13:14 schrieb Melissa Wen:
> Hi,
>
> Sorry for the noise, but while I've been working on wiring 3D LUT
> support to AMD display driver [1] I found some annoying code style
> issues in the shared-code part. So I'm just sending what I've been
> cleaning to better examine the code.
>
> Most seem trivial, except the last one "remove unused
> _calculate_degamma_curve" since this could just be a matter of missing
> parts. If so, happy to remove the patch and include a comment describing
> the situation (or the potential usage of it).

The display stack is not my field of expertise, but those cleanups are 
so obvious that I think I can safely give my Reviewed-by: Christian 
König <christian.koenig at amd.com> for the entire series.

Thanks,
Christian.

>
> Thanks,
>
> Melissa
>
> [1] https://lore.kernel.org/dri-devel/20230109143846.1966301-1-mwen@igalia.com/
>
> Melissa Wen (6):
>    drm/amd/display: ident braces in dcn30_acquire_post_bldn_3dlut
>      correctly
>    drm/amd/display: clean code-style issues in dcn30_set_mpc_shaper_3dlut
>    drm/amd/display: camel case cleanup in color_gamma file
>    drm/amd/display: unset initial value for tf since it's never used
>    drm/amd/display: remove unused func declaration from resource headers
>    drm/amd/display: remove unused _calculate_degamma_curve function
>
>   .../drm/amd/display/dc/dcn30/dcn30_hwseq.c    |  37 ++---
>   .../drm/amd/display/dc/dcn30/dcn30_resource.c |   2 +-
>   drivers/gpu/drm/amd/display/dc/inc/resource.h |   4 -
>   .../amd/display/modules/color/color_gamma.c   | 140 ++++--------------
>   .../amd/display/modules/color/color_gamma.h   |   3 -
>   5 files changed, 48 insertions(+), 138 deletions(-)
>



More information about the amd-gfx mailing list