[PATCH] drm/amdgpu: remove TOPDOWN flags when allocating VRAM in large bar system

Christian König christian.koenig at amd.com
Wed Feb 15 06:44:17 UTC 2023


Am 15.02.23 um 06:25 schrieb Shane Xiao:
> Since VRAM manager is changed from drm mm to drm buddy, the
> TOP_DOWN flag should not be set by default in the large bar system.
> Removing this flag helps improve drm buddy allactor efficiency and
> reduce the risk of splitting higher order block into lower order.
>
> Signed-off-by: Shane Xiao <shane.xiao at amd.com>

Reviewed-by: Christian König <christian.koenig at amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> index 2d237f3d3a2e..1c3e647400bd 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> @@ -139,7 +139,7 @@ void amdgpu_bo_placement_from_domain(struct amdgpu_bo *abo, u32 domain)
>   
>   		if (flags & AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED)
>   			places[c].lpfn = visible_pfn;
> -		else
> +		else if (adev->gmc.real_vram_size != adev->gmc.visible_vram_size)
>   			places[c].flags |= TTM_PL_FLAG_TOPDOWN;
>   
>   		if (flags & AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS)



More information about the amd-gfx mailing list