[RFC 3/7] drm/amdgpu: Create MQD for userspace queue

[Christian König]

Am 04.01.23 um 07:21 schrieb Yadav, Arvind:
>
> On 1/4/2023 12:07 AM, Felix Kuehling wrote:
>> Am 2023-01-03 um 04:36 schrieb Shashank Sharma:
>>>>> /*MQD struct for usermode Queue*/
>>>>> +struct amdgpu_usermode_queue_mqd
>>>> This is specific to GC 11.  Every IP and version will have its own MQD
>>>> format.  That should live in the IP specific code, not the generic
>>>> code.  We already have the generic MQD parameters that we need from
>>>> the userq IOCTL.
>>>
>>> Noted, we can separate out the generic parameters from gen specific 
>>> parameter, and will try to wrap it around the generic structure.
>>>
>>> - Shashank
>>
>> Is there a reason why you can't use "struct v11_compute_mqd" from 
>> v11_structs.h?
>
> Hi Felix,
>
> Yes,  V11_compute_mqd does not have these below member which is needed 
> for usermode queue.
>
>     uint32_t shadow_base_lo; // offset: 0  (0x0)
>     uint32_t shadow_base_hi; // offset: 1  (0x1)
>     uint32_t gds_bkup_base_lo ; // offset: 2  (0x2)
>     uint32_t gds_bkup_base_hi ; // offset: 3  (0x3)
>     uint32_t fw_work_area_base_lo; // offset: 4  (0x4)
>     uint32_t fw_work_area_base_hi; // offset: 5  (0x5)
>     uint32_t shadow_initialized; // offset: 6  (0x6)
>     uint32_t ib_vmid; // offset: 7  (0x7)
>
> So we had to add new MQD structs.

Would it make more sense to update the existing MQD structures than 
adding new ones?

Regards,
Christian.

>
> thanks
>
> ~arvind
>
>>
>> Regards,
>>   Felix
>>