[PATCH 7/8] drm/amd/pm: drop the support for manual fan speed setting on SMU13.0.0

Lazar, Lijo lijo.lazar at amd.com
Thu Jan 5 14:08:13 UTC 2023



On 1/5/2023 8:52 AM, Evan Quan wrote:
> Due to lack of support from PMFW.
> 
> Signed-off-by: Evan Quan <evan.quan at amd.com>
> Change-Id: I5d466d3d521b26a484bd837e173b9b289d4020ec
> ---
>   drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c
> index 75c9f510e713..59cd68862973 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c
> @@ -2061,4 +2061,9 @@ void smu_v13_0_0_set_ppt_funcs(struct smu_context *smu)
>   					      BIT_ULL(AMD_SYSFS_IF_PP_DPM_DCEFCLK_BIT) |
>   					      BIT_ULL(AMD_SYSFS_IF_PP_SCLK_OD_BIT) |
>   					      BIT_ULL(AMD_SYSFS_IF_PP_MCLK_OD_BIT));
> +	/* Drop the support for manual fan speed(RPM and PWM) setting */
> +	smu->adev->pm.hwmon_if_attr_mode[AMD_HWMON_IF_PWM1_ENABLE_BIT] &= ~S_IWUSR;
> +	smu->adev->pm.hwmon_if_attr_mode[AMD_HWMON_IF_PWM1_BIT] &= ~S_IWUSR;
> +	smu->adev->pm.hwmon_if_attr_mode[AMD_HWMON_IF_FAN1_ENABLE_BIT] &= ~S_IWUSR;
> +	smu->adev->pm.hwmon_if_attr_mode[AMD_HWMON_IF_FAN1_TARGET_BIT] &= ~S_IWUSR;

This will be taken care if you set the corresponding set ppt funcs to NULL.

Thanks,
Lijo

>   }


More information about the amd-gfx mailing list