[PATCH 0/9] Reduce stack size for DCN31/314

Rodrigo Siqueira Rodrigo.Siqueira at amd.com
Tue Jan 10 15:43:16 UTC 2023


Geert Uytterhoeven reported compiler issues in some specific gcc
versions that point to a large stack size for DCN31/314. Unfortunately,
I could not reproduce the problem with the latest version of GCC/Clang;
but I still believe this is a valid issue. Therefore, this patchset
attempts to address those issues by moving many arrays of doubles from
the local declaration to some specific structs. The first patch in this
series introduces the new struct, and the subsequent patches move arrays
of doubles from the local function in favor of using those values from
the struct.

Geert Uytterhoeven, since I don't have a simple way to reproduce this
issue, could you run the CI in this series to check if this patchset
solves the issues?

Cc: Alex Deucher <alexdeucher at gmail.com>
Cc: Aurabindo Pillai <aurabindo.pillai at amd.com>
Cc: Hamza Mahfooz <hamza.mahfooz at amd.com>
Cc: Roman Li <roman.li at amd.com>
Cc: Harry Wentland <harry.wentland at amd.com>
Cc: Geert Uytterhoeven <geert at linux-m68k.org>
Link: https://lore.kernel.org/all/20221227082932.798359-1-geert@linux-m68k.org/

Thanks
Siqueira

Rodrigo Siqueira (9):
  drm/amd/display: Introduce UseMinimumDCFCLK_vars to reduce stack size
    in DML
  drm/amd/display: Move two arrays of doubles to UseMinimumDCFCLK_vars
  drm/amd/display: Move DCFCLKRequiredForPeakBandwidthPerPlane to
    UseMinimumDCFCLK_vars
  drm/amd/display: Move DynamicMetadataVMExtraLatency to
    UseMinimumDCFCLK_vars
  drm/amd/display: Use matrix of double from struct instead of local
    variable
  drm/amd/display: Use PixelDCFCLKCyclesRequiredInPrefetch from struct
  drm/amd/display: Use PrefetchPixelLinesTime from struct instead of
    local variable
  drm/amd/display: Use DCFCLKRequiredForPeakBandwidthPerPlane from
    struct
  drm/amd/display: Use DynamicMetadataVMExtraLatency from struct

 .../dc/dml/dcn31/display_mode_vba_31.c        | 49 +++++++++----------
 .../dc/dml/dcn314/display_mode_vba_314.c      | 49 +++++++++----------
 .../drm/amd/display/dc/dml/display_mode_vba.h |  9 ++++
 3 files changed, 53 insertions(+), 54 deletions(-)

-- 
2.39.0



More information about the amd-gfx mailing list