[PATCH] drm/amdgpu/smu: skip pptable init under sriov

Alex Deucher alexdeucher at gmail.com
Fri Jan 13 14:40:03 UTC 2023


On Fri, Jan 13, 2023 at 5:56 AM Jane Jian <Jane.Jian at amd.com> wrote:
>
> sriov does not need to init pptable from amdgpu driver
> we finish it from PF
>
> Signed-off-by: Jane Jian <Jane.Jian at amd.com>
> ---
>  drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c
> index d0cdc578344d..d07b0cfe23b4 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c
> @@ -407,6 +407,9 @@ static int smu_v13_0_0_setup_pptable(struct smu_context *smu)
>         struct amdgpu_device *adev = smu->adev;
>         int ret = 0;
>
> +       if(amdgpu_sriov_vf(smu->adev))

Space between if and (.

> +               return 0;
> +
>         ret = smu_v13_0_0_get_pptable_from_pmfw(smu,
>                                                 &smu_table->power_play_table,
>                                                 &smu_table->power_play_table_size);
> @@ -1257,6 +1260,9 @@ static int smu_v13_0_0_get_thermal_temperature_range(struct smu_context *smu,
>                 table_context->power_play_table;
>         PPTable_t *pptable = smu->smu_table.driver_pptable;
>
> +       if(amdgpu_sriov_vf(smu->adev))

Space between if and (.

with those fixed:
Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> +               return 0;
> +
>         if (!range)
>                 return -EINVAL;
>
> --
> 2.17.1
>


More information about the amd-gfx mailing list