[PATCH 21/37] drm/amd/display: move dp capability related logic to link_dp_capability

[Alex Deucher]

Arnd already sent a patch to fix this. It should show up in my next
drm-next update.

Alex

On Thu, Jan 19, 2023 at 1:55 PM Conor Dooley <conor.dooley at microchip.com> wrote:
>
> Hello!
>
> On Tue, Jan 10, 2023 at 11:55:19AM -0500, Rodrigo Siqueira wrote:
> > From: Wenjing Liu <wenjing.liu at amd.com>
> >
> > Reviewed-by: Wesley Chalmers <Wesley.Chalmers at amd.com>
> > Acked-by: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>
> > Signed-off-by: Wenjing Liu <wenjing.liu at amd.com>
>
> I haven't done a bisection, but I am getting build failures due to code
> added by this patch (d5a43956b73bd in next-20230119) when running
> allmodconfig for RISC-V with gcc-11.
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_dp_capability.c:233:21: error: 'union hdmi_encoded_link_bw' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
>
>   233 |         const union hdmi_encoded_link_bw hdmi_encoded_link_bw)
>
>       |                     ^~~~~~~~~~~~~~~~~~~~
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_dp_capability.c:233:42: error: parameter 2 ('hdmi_encoded_link_bw') has incomplete type
>
>   233 |         const union hdmi_encoded_link_bw hdmi_encoded_link_bw)
>
>       |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_dp_capability.c:231:17: error: function declaration isn't a prototype [-Werror=strict-prototypes]
>
>   231 | static uint32_t intersect_frl_link_bw_support(
>
>       |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_dp_capability.c: In function 'get_active_converter_info':
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_dp_capability.c:1125:76: error: storage size of 'hdmi_encoded_link_bw' isn't known
>
>  1125 |                                                 union hdmi_encoded_link_bw hdmi_encoded_link_bw;
>
>       |                                                                            ^~~~~~~~~~~~~~~~~~~~
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_dp_capability.c:1129:101: error: 'struct <anonymous>' has no member named 'MAX_ENCODED_LINK_BW_SUPPORT'
>
>  1129 |                                                                                 hdmi_color_caps.bits.MAX_ENCODED_LINK_BW_SUPPORT);
>
>       |                                                                                                     ^
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_dp_capability.c:1125:76: error: unused variable 'hdmi_encoded_link_bw' [-Werror=unused-variable]
>
>  1125 |                                                 union hdmi_encoded_link_bw hdmi_encoded_link_bw;
>
>       |                                                                            ^~~~~~~~~~~~~~~~~~~~
>
> cc1: all warnings being treated as errors
>
> Thanks,
> Conor.
>