[PATCH v2] drm/amd/pm: disbale dcefclk device sysnode on GFX v9.4.3 chip

[Lazar, Lijo]

On 7/5/2023 11:16 AM, Yang Wang wrote:
> v1:
> the dceflck sysnode is not aviable on GFX v9.4.3 chip.
> 
> v2:
> simplify code logic using helper function: amdgpu_device_has_display_hardware().
> 
> Signed-off-by: Yang Wang <kevinyang.wang at amd.com>
> Reviewed-by: Kenneth Feng <kenneth.feng at amd.com>
> ---
>   drivers/gpu/drm/amd/pm/amdgpu_pm.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> index 9ef88a0b1b57..f6724d633e45 100644
> --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> +++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> @@ -2048,9 +2048,7 @@ static int default_attr_update(struct amdgpu_device *adev, struct amdgpu_device_
>   		if (gc_ver < IP_VERSION(9, 0, 0))
>   			*states = ATTR_STATE_UNSUPPORTED;
>   	} else if (DEVICE_ATTR_IS(pp_dpm_dcefclk)) {
> -		if (gc_ver < IP_VERSION(9, 0, 0) ||

Missed this - this remains (no DCEF for old HW) and rest may be replaced 
with presence of display controller.

Thanks,
Lijo

> -		    gc_ver == IP_VERSION(9, 4, 1) ||
> -		    gc_ver == IP_VERSION(9, 4, 2))
> +		if (!amdgpu_device_has_display_hardware(adev))
>   			*states = ATTR_STATE_UNSUPPORTED;
>   	} else if (DEVICE_ATTR_IS(pp_dpm_fclk)) {
>   		if (mp1_ver < IP_VERSION(10, 0, 0))