[PATCH 6/6] drm/amd/display: Eliminate warnings in amdgpu_dm_helpers.c

[Aurabindo Pillai]

On 6/29/2023 12:46 AM, Srinivasan Shanmugam wrote:
> Fix the following warnings reported by checkpatch:
> 
> WARNING: Block comments use a trailing */ on a separate line
> WARNING: Prefer using '"%s...", __func__' to using 'execute_synaptics_rc_command', this function's name, in a string
> WARNING: Prefer using '"%s...", __func__' to using 'apply_synaptics_fifo_reset_wa', this function's name, in a string
> WARNING: braces {} are not necessary for single statement blocks
> 
> Cc: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>
> Cc: Aurabindo Pillai <aurabindo.pillai at amd.com>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam at amd.com>
> ---
>   .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 29 +++++++++----------
>   1 file changed, 14 insertions(+), 15 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
> index a6be04ad387f..66909bb5e5b0 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
> @@ -68,15 +68,13 @@ static void apply_edid_quirks(struct edid *edid, struct dc_edid_caps *edid_caps)
>   	}
>   }
>   
> -/* dm_helpers_parse_edid_caps
> +/**
> + * dm_helpers_parse_edid_caps() - Parse edid caps
>    *
> - * Parse edid caps
> + * @edid_caps:	[in] pointer to edid caps
>    *
> - * @edid:	[in] pointer to edid
> - *  edid_caps:	[in] pointer to edid caps
> - * @return
> - *	void
> - * */
> + * Return: void
> + */
>   enum dc_edid_status dm_helpers_parse_edid_caps(
>   		struct dc_link *link,
>   		const struct dc_edid *edid,
> @@ -255,7 +253,8 @@ bool dm_helpers_dp_mst_write_payload_allocation_table(
>   	/* Accessing the connector state is required for vcpi_slots allocation
>   	 * and directly relies on behaviour in commit check
>   	 * that blocks before commit guaranteeing that the state
> -	 * is not gonna be swapped while still in use in commit tail */
> +	 * is not gonna be swapped while still in use in commit tail
> +	 */
>   
>   	if (!aconnector || !aconnector->mst_root)
>   		return false;
> @@ -282,7 +281,8 @@ bool dm_helpers_dp_mst_write_payload_allocation_table(
>   	/* mst_mgr->->payloads are VC payload notify MST branch using DPCD or
>   	 * AUX message. The sequence is slot 1-63 allocated sequence for each
>   	 * stream. AMD ASIC stream slot allocation should follow the same
> -	 * sequence. copy DRM MST allocation to dc */
> +	 * sequence. copy DRM MST allocation to dc
> +	 */
>   	fill_dc_mst_payload_table_from_drm(stream->link, enable, target_payload, proposed_table);
>   
>   	return true;
> @@ -633,7 +633,7 @@ static bool execute_synaptics_rc_command(struct drm_dp_aux *aux,
>   	ret = drm_dp_dpcd_write(aux, SYNAPTICS_RC_COMMAND, &rc_cmd, sizeof(rc_cmd));
>   
>   	if (ret < 0) {
> -		DRM_ERROR("	execute_synaptics_rc_command - write cmd ..., err = %d\n", ret);
> +		DRM_ERROR("%s: write cmd ..., err = %d\n",  __func__, ret);
>   		return false;
>   	}
>   
> @@ -655,7 +655,7 @@ static bool execute_synaptics_rc_command(struct drm_dp_aux *aux,
>   		drm_dp_dpcd_read(aux, SYNAPTICS_RC_DATA, data, length);
>   	}
>   
> -	DC_LOG_DC("	execute_synaptics_rc_command - success = %d\n", success);
> +	DC_LOG_DC("%s: success = %d\n", __func__, success);
>   
>   	return success;
>   }
> @@ -664,7 +664,7 @@ static void apply_synaptics_fifo_reset_wa(struct drm_dp_aux *aux)
>   {
>   	unsigned char data[16] = {0};
>   
> -	DC_LOG_DC("Start apply_synaptics_fifo_reset_wa\n");
> +	DC_LOG_DC("Start %s\n", __func__);
>   
>   	// Step 2
>   	data[0] = 'P';
> @@ -722,7 +722,7 @@ static void apply_synaptics_fifo_reset_wa(struct drm_dp_aux *aux)
>   	if (!execute_synaptics_rc_command(aux, true, 0x02, 0, 0, NULL))
>   		return;
>   
> -	DC_LOG_DC("Done apply_synaptics_fifo_reset_wa\n");
> +	DC_LOG_DC("Done %s\n", __func__);
>   }
>   
>   /* MST Dock */
> @@ -995,9 +995,8 @@ void dm_helpers_override_panel_settings(
>   	struct dc_panel_config *panel_config)
>   {
>   	// Feature DSC
> -	if (amdgpu_dc_debug_mask & DC_DISABLE_DSC) {
> +	if (amdgpu_dc_debug_mask & DC_DISABLE_DSC)
>   		panel_config->dsc.disable_dsc_edp = true;
> -	}
>   }
>   
>   void *dm_helpers_allocate_gpu_mem(

Reviewed-by: Aurabindo Pillai <aurabindo.pillai at amd.com>