[PATCH] drm/amdgpu: allow secure submission on VCN4 ring

Leo Liu leo.liu at amd.com
Tue Jul 18 13:08:11 UTC 2023


Reviewed-by: Leo Liu <leo.liu at amd.com>

On 2023-07-17 13:27, sguttula wrote:
> This patch will enable secure decode playback on VCN4_0_2
>
> Signed-off-by: sguttula <Suresh.Guttula at amd.com>
>
> ---
> Changes in v2:
> -updated commit message only enabling for VCN402
> -updated the logic as per Leo's feedback
> ---
>   drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c | 8 ++++++--
>   1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c
> index e8c02ae10163..d2d89bb711b0 100644
> --- a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c
> @@ -1801,7 +1801,7 @@ static int vcn_v4_0_ring_patch_cs_in_place(struct amdgpu_cs_parser *p,
>   	return 0;
>   }
>   
> -static const struct amdgpu_ring_funcs vcn_v4_0_unified_ring_vm_funcs = {
> +static struct amdgpu_ring_funcs vcn_v4_0_unified_ring_vm_funcs = {
>   	.type = AMDGPU_RING_TYPE_VCN_ENC,
>   	.align_mask = 0x3f,
>   	.nop = VCN_ENC_CMD_NO_OP,
> @@ -1846,7 +1846,11 @@ static void vcn_v4_0_set_unified_ring_funcs(struct amdgpu_device *adev)
>   		if (adev->vcn.harvest_config & (1 << i))
>   			continue;
>   
> -		adev->vcn.inst[i].ring_enc[0].funcs = &vcn_v4_0_unified_ring_vm_funcs;
> +		if (adev->ip_versions[VCN_HWIP][0] == IP_VERSION(4, 0, 2))
> +			vcn_v4_0_unified_ring_vm_funcs.secure_submission_supported = true;
> +
> +		adev->vcn.inst[i].ring_enc[0].funcs =
> +		       (const struct amdgpu_ring_funcs *)&vcn_v4_0_unified_ring_vm_funcs;
>   		adev->vcn.inst[i].ring_enc[0].me = i;
>   
>   		DRM_INFO("VCN(%d) encode/decode are enabled in VM mode\n", i);


More information about the amd-gfx mailing list