RE: [PATCH] drm/amdgpu: Fix unused variable ‘idx’ in ‘amdgpu_atom_parse’

[Chen, Guchun]

[Public]

Reviewed-by: Guchun Chen <guchun.chen at amd.com>

> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of
> Srinivasan Shanmugam
> Sent: Wednesday, July 19, 2023 1:29 PM
> To: Koenig, Christian <Christian.Koenig at amd.com>; Deucher, Alexander
> <Alexander.Deucher at amd.com>
> Cc: SHANMUGAM, SRINIVASAN <SRINIVASAN.SHANMUGAM at amd.com>;
> amd-gfx at lists.freedesktop.org
> Subject: [PATCH] drm/amdgpu: Fix unused variable ‘idx’ in
> ‘amdgpu_atom_parse’
>
> drivers/gpu/drm/amd/amdgpu/atom.c: In function ‘amdgpu_atom_parse’:
> drivers/gpu/drm/amd/amdgpu/atom.c:1468:6: warning: unused variable
> ‘idx’ [-Wunused-variable]
>  1468 |  u16 idx;
>       |      ^~~
>
> Cc: Christian König <christian.koenig at amd.com>
> Cc: Alex Deucher <alexander.deucher at amd.com>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/atom.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/atom.c
> b/drivers/gpu/drm/amd/amdgpu/atom.c
> index edbb862c1025..9f63ddb89b75 100644
> --- a/drivers/gpu/drm/amd/amdgpu/atom.c
> +++ b/drivers/gpu/drm/amd/amdgpu/atom.c
> @@ -1465,7 +1465,6 @@ struct atom_context *amdgpu_atom_parse(struct
> card_info *card, void *bios)
>       struct _ATOM_ROM_HEADER *atom_rom_header;
>       struct _ATOM_MASTER_DATA_TABLE *master_table;
>       struct _ATOM_FIRMWARE_INFO *atom_fw_info;
> -     u16 idx;
>
>       if (!ctx)
>               return NULL;
> --
> 2.25.1

-------------- next part --------------
A non-text attachment was scrubbed...
Name: winmail.dat
Type: application/ms-tnef
Size: 15769 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20230719/ca8cbb3c/attachment-0001.bin>