[PATCH 2/2] drm/radeon: Prefer dev_warn over printk

[Alex Deucher]

On Wed, Jul 19, 2023 at 1:20 AM Srinivasan Shanmugam
<srinivasan.shanmugam at amd.com> wrote:
>
> From: Srinivasan Shanmugam <srinivasan.shanmugam at amd.corp-partner.google.com>
>
> Fixes the following checkpatch.pl:
>
> WARNING: printk() should include KERN_<LEVEL> facility level

Might be better to convert to dev_* variants so that we get better
info when there are multiple GPUs in the system.

Alex

>
> Cc: Christian König <christian.koenig at amd.com>
> Cc: Alex Deucher <alexander.deucher at amd.com>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam at amd.com>
> ---
>  drivers/gpu/drm/radeon/radeon_atpx_handler.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_atpx_handler.c b/drivers/gpu/drm/radeon/radeon_atpx_handler.c
> index d0b450a06506..875a995fff66 100644
> --- a/drivers/gpu/drm/radeon/radeon_atpx_handler.c
> +++ b/drivers/gpu/drm/radeon/radeon_atpx_handler.c
> @@ -115,7 +115,7 @@ static union acpi_object *radeon_atpx_call(acpi_handle handle, int function,
>
>         /* Fail only if calling the method fails and ATPX is supported */
>         if (ACPI_FAILURE(status) && status != AE_NOT_FOUND) {
> -               printk("failed to evaluate ATPX got %s\n",
> +               pr_err("failed to evaluate ATPX got %s\n",
>                        acpi_format_exception(status));
>                 kfree(buffer.pointer);
>                 return NULL;
> @@ -171,7 +171,7 @@ static int radeon_atpx_validate(struct radeon_atpx *atpx)
>
>                 size = *(u16 *) info->buffer.pointer;
>                 if (size < 10) {
> -                       printk("ATPX buffer is too small: %zu\n", size);
> +                       pr_err("ATPX buffer is too small: %zu\n", size);
>                         kfree(info);
>                         return -EINVAL;
>                 }
> @@ -202,7 +202,7 @@ static int radeon_atpx_validate(struct radeon_atpx *atpx)
>
>         atpx->is_hybrid = false;
>         if (valid_bits & ATPX_MS_HYBRID_GFX_SUPPORTED) {
> -               printk("ATPX Hybrid Graphics\n");
> +               pr_info("ATPX Hybrid Graphics\n");
>                 /*
>                  * Disable legacy PM methods only when pcie port PM is usable,
>                  * otherwise the device might fail to power off or power on.
> @@ -239,7 +239,7 @@ static int radeon_atpx_verify_interface(struct radeon_atpx *atpx)
>
>         size = *(u16 *) info->buffer.pointer;
>         if (size < 8) {
> -               printk("ATPX buffer is too small: %zu\n", size);
> +               pr_err("ATPX buffer is too small: %zu\n", size);
>                 err = -EINVAL;
>                 goto out;
>         }
> @@ -248,7 +248,7 @@ static int radeon_atpx_verify_interface(struct radeon_atpx *atpx)
>         memcpy(&output, info->buffer.pointer, size);
>
>         /* TODO: check version? */
> -       printk("ATPX version %u, functions 0x%08x\n",
> +       pr_info("ATPX version %u, functions 0x%08x\n",
>                output.version, output.function_bits);
>
>         radeon_atpx_parse_functions(&atpx->functions, output.function_bits);
> --
> 2.25.1
>