[PATCH v2] drm/amd/display: Use root connector's colorspace property for MST

[Michel Dänzer]

On 7/14/23 18:52, Michel Dänzer wrote:
> On 7/13/23 21:58, Harry Wentland wrote:
>> After driver init we shouldn't create new properties. Doing so
>> will lead to a warning storm from __drm_mode_object_add.
>>
>> We don't really need to create the property for MST connectors.
>> Re-using the mst_root connector's property is fine.
>>
>> v2: Add curly braces to avoid possibly 'else' confusion
> 
> I'm still hitting WARNINGs with this, see attachment.

It's because drm_connector_attach_colorspace_property tries attaching the property to the MST root connector again, instead of to the newly created MST connector.

I tried the attached patch on top and didn't get any WARNINGs, but for some reason the MST connector for my external monitor never showed up to user space. Not sure what's going on there.


-- 
Earthling Michel Dänzer            |                  https://redhat.com
Libre software enthusiast          |         Mesa and Xwayland developer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-drm-amd-display-Fix-attaching-root-colorspace-proper.patch
Type: text/x-patch
Size: 1705 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20230728/812c8050/attachment.bin>