[PATCH 1/3] drm/amdkfd: add event age tracking

[Felix Kuehling]

We'll also need a pointer to the user mode changes in some public repo, 
or a public email code review of the user mode changes.

Thanks,
   Felix


On 2023-06-01 16:58, Felix Kuehling wrote:
> On 2023-06-01 16:47, James Zhu wrote:
>> Add event age tracking
>>
>> Signed-off-by: James Zhu <James.Zhu at amd.com>
>> ---
>>   include/uapi/linux/kfd_ioctl.h | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/uapi/linux/kfd_ioctl.h 
>> b/include/uapi/linux/kfd_ioctl.h
>> index 7e19a2d1e907..bfbe0006370e 100644
>> --- a/include/uapi/linux/kfd_ioctl.h
>> +++ b/include/uapi/linux/kfd_ioctl.h
>> @@ -38,9 +38,10 @@
>>    * - 1.10 - Add SMI profiler event log
>>    * - 1.11 - Add unified memory for ctx save/restore area
>>    * - 1.12 - Add DMA buf export ioctl
>> + * - 1.13 - Update kfd_event_data
>>    */
>>   #define KFD_IOCTL_MAJOR_VERSION 1
>> -#define KFD_IOCTL_MINOR_VERSION 12
>> +#define KFD_IOCTL_MINOR_VERSION 13
>
> I think minor version 13 is used for the debugger changes that are 
> making their way into the upstream branch right now. You'll probably 
> have to rebase this and use minor version 14 for this.
>
>
>>     /*
>>    * Debug revision change log
>> @@ -693,6 +694,7 @@ struct kfd_event_data {
>>       union {
>>           struct kfd_hsa_memory_exception_data memory_exception_data;
>>           struct kfd_hsa_hw_exception_data hw_exception_data;
>> +        __u64 last_event_age;    /* to and from KFD */
>
> It would be better to create a new struct kfd_hsa_signal_event_data 
> for this to make it obvious what type of event it applies to. And to 
> keep the union more uniform.
>
> Regards,
>   Felix
>
>
>>       };                /* From KFD */
>>       __u64 kfd_event_data_ext;    /* pointer to an extension structure
>>                          for future exception types */