[PATCH 1/1] drm/amdgpu/pm: notify driver unloading to PMFW for SMU v13.0.6 dGPU

Zhang, Hawking Hawking.Zhang at amd.com
Fri Jun 2 03:16:35 UTC 2023


[AMD Official Use Only - General]

Reviewed-by: Hawking Zhang <Hawking.Zhang at amd.com>

Regards,
Hawking
-----Original Message-----
From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of Le Ma
Sent: Friday, June 2, 2023 10:42
To: amd-gfx at lists.freedesktop.org
Cc: Ma, Le <Le.Ma at amd.com>; Lazar, Lijo <Lijo.Lazar at amd.com>; Zhang, Morris <Shiwu.Zhang at amd.com>
Subject: [PATCH 1/1] drm/amdgpu/pm: notify driver unloading to PMFW for SMU v13.0.6 dGPU

Per requested, follow the same sequence as APU to send only PPSMC_MSG_PrepareForDriverUnload to PMFW during driver unloading.

Change-Id: I2dc8495572b0bce6e21eafb51b215c83d94ac647
Signed-off-by: Le Ma <le.ma at amd.com>
Reviewed-by: Shiwu Zhang <shiwu.zhang at amd.com>
Reviewed-by: Lijo Lazar <lijo.lazar at amd.com>
---
 .../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
index 3da614faf75d..392ccebc8dac 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
@@ -1409,18 +1409,16 @@ static int smu_v13_0_6_system_features_control(struct smu_context *smu,
                                              bool enable)
 {
        struct amdgpu_device *adev = smu->adev;
-       int ret;
-
-       /* On APUs, notify FW that the device is no longer driver managed */
-       if (adev->flags & AMD_IS_APU) {
-               if (!enable)
-                       smu_v13_0_6_notify_unload(smu);
+       int ret = 0;

-               return 0;
+       if (enable) {
+               if (!(adev->flags & AMD_IS_APU))
+                       ret = smu_v13_0_system_features_control(smu, enable);
+       } else {
+               /* Notify FW that the device is no longer driver managed */
+               smu_v13_0_6_notify_unload(smu);
        }

-       ret = smu_v13_0_system_features_control(smu, enable);
-
        return ret;
 }

--
2.38.1



More information about the amd-gfx mailing list