[PATCH 10/66] drm/amd/display: Do not set drr on pipe commit

[Pillai, Aurabindo]

[Public]

Hi Michel,

AMD driver package also contains various firmware that could make a difference. Even though I do not expect any major deltas for Navi21 at this point, its an extra variable in the equation that could potentially create a different behaviour.

We tried upstream stack (without any AMD packaged driver) on Ubuntu 22.04 on the same display that you reported the issue on, but couldn't reproduce the hang you're seeing (using a different steam game that uses the same framework). Maybe your custom gnome build could have affected the results too. Could you provide instructions for setting up your userspace environment ?

Other than the game, is there any other workload that could trigger the hang? We have a set of IGT tests you could try:

Repo: https://gitlab.freedesktop.org/drm/igt-gpu-tools

Build & install:

meson build

# Compile IGT
ninja -C build

# Download Piglit
./scripts/run-tests.sh -d

Run tests
./scripts/run-tests.sh -s -T /path/to/navi21_postsubmission.testlist


--

Regards,
Jay
________________________________
From: Michel Dänzer <michel at daenzer.net>
Sent: Thursday, June 1, 2023 11:53 AM
To: Pillai, Aurabindo <Aurabindo.Pillai at amd.com>; Zhuo, Qingqing (Lillian) <Qingqing.Zhuo at amd.com>; amd-gfx at lists.freedesktop.org <amd-gfx at lists.freedesktop.org>; Chalmers, Wesley <Wesley.Chalmers at amd.com>
Cc: Wang, Chao-kai (Stylon) <Stylon.Wang at amd.com>; Li, Sun peng (Leo) <Sunpeng.Li at amd.com>; Lakha, Bhawanpreet <Bhawanpreet.Lakha at amd.com>; Siqueira, Rodrigo <Rodrigo.Siqueira at amd.com>; Li, Roman <Roman.Li at amd.com>; Chiu, Solomon <Solomon.Chiu at amd.com>; Lin, Wayne <Wayne.Lin at amd.com>; Wentland, Harry <Harry.Wentland at amd.com>; Gutierrez, Agustin <Agustin.Gutierrez at amd.com>; Kotarac, Pavle <Pavle.Kotarac at amd.com>
Subject: Re: [PATCH 10/66] drm/amd/display: Do not set drr on pipe commit

On 6/1/23 17:45, Pillai, Aurabindo wrote:
>
> I see, thanks for the info. I'll try repro'ing it locally.

Thanks. Note that I'm using a GNOME Wayland session, which doesn't support VRR upstream yet (I'm building mutter with https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1154 for that). I don't know if it's reproducible with Xorg.


> But do you have the open userspace stack from AMD's packaged driver installed ? If not, could you please try downloading from https://www.amd.com/en/support/linux-drivers <https://www.amd.com/en/support/linux-drivers> and install just the open components?

I don't, and I'd rather not unless it's absolutely necessary. I'm not sure how the user-space drivers could affect this.

I'll happily test further patches though.


--
Earthling Michel Dänzer            |                  https://redhat.com
Libre software enthusiast          |         Mesa and Xwayland developer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20230602/df1d9a63/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: navi21_postsubmission.testlist
Type: application/octet-stream
Size: 15280 bytes
Desc: navi21_postsubmission.testlist
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20230602/df1d9a63/attachment-0001.obj>