[PATCH] amd/amdkfd: drop unused KFD_IOCTL_SVM_FLAG_UNCACHED flag

Bhardwaj, Rajneesh rajneesh.bhardwaj at amd.com
Fri Jun 2 17:13:58 UTC 2023


I think the case for MTYPE_UC still needs to be dealt with for svm 
ranges but the UNCACHED flag here looks misplaced and should be removed 
, other than that it looks good, reviewed-by: Rajneesh Bhardwaj 
<rajneesh.bhardwaj at amd.com>

On 6/2/2023 1:01 PM, Alex Deucher wrote:
> Was leftover from GC 9.4.3 bring up and is currently
> unused.  Drop it for now.
>
> Cc: Philip.Yang at amd.com
> Cc: rajneesh.bhardwaj at amd.com
> Cc: Felix.Kuehling at amd.com
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 2 +-
>   include/uapi/linux/kfd_ioctl.h       | 2 --
>   2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
> index 615eab3f78c9..5ff1a5a89d96 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
> @@ -1154,7 +1154,7 @@ svm_range_get_pte_flags(struct kfd_node *node,
>   	uint64_t pte_flags;
>   	bool snoop = (domain != SVM_RANGE_VRAM_DOMAIN);
>   	bool coherent = flags & KFD_IOCTL_SVM_FLAG_COHERENT;
> -	bool uncached = flags & KFD_IOCTL_SVM_FLAG_UNCACHED;
> +	bool uncached = false; /*flags & KFD_IOCTL_SVM_FLAG_UNCACHED;*/
>   	unsigned int mtype_local;
>   
>   	if (domain == SVM_RANGE_VRAM_DOMAIN)
> diff --git a/include/uapi/linux/kfd_ioctl.h b/include/uapi/linux/kfd_ioctl.h
> index 2a9671e1ddb5..2da5c3ad71bd 100644
> --- a/include/uapi/linux/kfd_ioctl.h
> +++ b/include/uapi/linux/kfd_ioctl.h
> @@ -623,8 +623,6 @@ enum kfd_mmio_remap {
>   #define KFD_IOCTL_SVM_FLAG_GPU_READ_MOSTLY     0x00000020
>   /* Keep GPU memory mapping always valid as if XNACK is disable */
>   #define KFD_IOCTL_SVM_FLAG_GPU_ALWAYS_MAPPED   0x00000040
> -/* Uncached access to memory */
> -#define KFD_IOCTL_SVM_FLAG_UNCACHED 0x00000080
>   
>   /**
>    * kfd_ioctl_svm_op - SVM ioctl operations


More information about the amd-gfx mailing list