[PATCH] drm/amd: Check that a system is a NUMA system before looking for SRAT

[Felix Kuehling]

On 2023-06-02 08:18, Mario Limonciello wrote:
> It's pointless on laptops to look for the SRAT table as these are not
> NUMA.  Check the number of possible nodes is > 1 to decide whether to
> look for SRAT.
>
> Suggested-by: Felix Kuehling <Felix.Kuehling at amd.com>
> Signed-off-by: Mario Limonciello <mario.limonciello at amd.com>

I think we discussed this a while ago and I don't remember the exact 
issue that was meant to fix. Was just to get rid of an irritating 
warning in the kernel log? Anyway, the patch looks good to me.

Reviewed-by: Felix Kuehling <Felix.Kuehling at amd.com>


> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> index 950af6820153..3dcd8f8bc98e 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> @@ -2041,7 +2041,8 @@ static int kfd_fill_gpu_direct_io_link_to_cpu(int *avail_size,
>   	sub_type_hdr->proximity_domain_from = proximity_domain;
>   
>   #ifdef CONFIG_ACPI_NUMA
> -	if (kdev->adev->pdev->dev.numa_node == NUMA_NO_NODE)
> +	if (kdev->adev->pdev->dev.numa_node == NUMA_NO_NODE &&
> +	    num_possible_nodes() > 1)
>   		kfd_find_numa_node_in_srat(kdev);
>   #endif
>   #ifdef CONFIG_NUMA