[PATCH v2 1/3] drm/amdkfd: add event age tracking

James Zhu jamesz at amd.com
Wed Jun 7 17:20:53 UTC 2023


On 2023-06-07 13:17, Felix Kuehling wrote:
> On 2023-06-06 12:24, James Zhu wrote:
>> Add event age tracking
>>
>> Signed-off-by: James Zhu <James.Zhu at amd.com>
>> ---
>>   include/uapi/linux/kfd_ioctl.h | 13 +++++++++++--
>>   1 file changed, 11 insertions(+), 2 deletions(-)
>>
>> diff --git a/include/uapi/linux/kfd_ioctl.h 
>> b/include/uapi/linux/kfd_ioctl.h
>> index 1781e7669982..eeb2fdcbdcb7 100644
>> --- a/include/uapi/linux/kfd_ioctl.h
>> +++ b/include/uapi/linux/kfd_ioctl.h
>> @@ -39,9 +39,10 @@
>>    * - 1.11 - Add unified memory for ctx save/restore area
>>    * - 1.12 - Add DMA buf export ioctl
>>    * - 1.13 - Add debugger API
>> + * - 1.14 - Update kfd_event_data
>>    */
>>   #define KFD_IOCTL_MAJOR_VERSION 1
>> -#define KFD_IOCTL_MINOR_VERSION 13
>> +#define KFD_IOCTL_MINOR_VERSION 14
>
> Bumping the version number should be done in the last patch in the 
> series, once the feature is fully enabled.
[JZ] Noted, Thanks!
>
> Regards,
>   Felix
>
>
>>     struct kfd_ioctl_get_version_args {
>>       __u32 major_version;    /* from KFD */
>> @@ -320,12 +321,20 @@ struct kfd_hsa_hw_exception_data {
>>       __u32 gpu_id;
>>   };
>>   +/* hsa signal event data */
>> +struct kfd_hsa_signal_event_data {
>> +    __u64 last_event_age;    /* to and from KFD */
>> +};
>> +
>>   /* Event data */
>>   struct kfd_event_data {
>>       union {
>> +        /* From KFD */
>>           struct kfd_hsa_memory_exception_data memory_exception_data;
>>           struct kfd_hsa_hw_exception_data hw_exception_data;
>> -    };                /* From KFD */
>> +        /* To and From KFD */
>> +        struct kfd_hsa_signal_event_data signal_event_data;
>> +    };
>>       __u64 kfd_event_data_ext;    /* pointer to an extension structure
>>                          for future exception types */
>>       __u32 event_id;        /* to KFD */


More information about the amd-gfx mailing list