[PATCH] drm/amd/display: Correct and remove excess function parameter names in kdoc
Rodrigo Siqueira Jordao
Rodrigo.Siqueira at amd.com
Mon Jun 12 13:20:58 UTC 2023
On 6/11/23 19:32, Srinivasan Shanmugam wrote:
> Fixes the following gcc with W=1:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/dcn32_fpu.c:872: warning: Excess function parameter 'drr_pipe' description in 'subvp_drr_schedulable'
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/dcn32_fpu.c:1030: warning: Cannot understand * ****************************************************
>
> Cc: Stylon Wang <stylon.wang at amd.com>
> Cc: Hamza Mahfooz <hamza.mahfooz at amd.com>
> Cc: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>
> Cc: Harry Wentland <harry.wentland at amd.com>
> Cc: Aurabindo Pillai <aurabindo.pillai at amd.com>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam at amd.com>
> ---
> .../gpu/drm/amd/display/dc/dml/dcn32/dcn32_fpu.c | 14 +++++---------
> 1 file changed, 5 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn32/dcn32_fpu.c b/drivers/gpu/drm/amd/display/dc/dml/dcn32/dcn32_fpu.c
> index 166123be4adc..e2bb2b9971f3 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml/dcn32/dcn32_fpu.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn32/dcn32_fpu.c
> @@ -854,10 +854,9 @@ static bool subvp_subvp_schedulable(struct dc *dc, struct dc_state *context)
> }
>
> /**
> - * subvp_drr_schedulable - Determine if SubVP + DRR config is schedulable
> + * subvp_drr_schedulable() - Determine if SubVP + DRR config is schedulable
> * @dc: current dc state
> * @context: new dc state
> - * @drr_pipe: DRR pipe_ctx for the SubVP + DRR config
> *
> * High level algorithm:
> * 1. Get timing for SubVP pipe, phantom pipe, and DRR pipe
> @@ -1027,19 +1026,16 @@ static bool subvp_vblank_schedulable(struct dc *dc, struct dc_state *context)
> }
>
> /**
> - * ************************************************************************************************
> - * subvp_subvp_admissable: Determine if subvp + subvp config is admissible
> + * subvp_subvp_admissable() - Determine if subvp + subvp config is admissible
> *
> - * @param [in]: dc: Current DC state
> - * @param [in]: context: New DC state to be programmed
> + * @dc: Current DC state
> + * @context: New DC state to be programmed
> *
> * SubVP + SubVP is admissible under the following conditions:
> * - All SubVP pipes are < 120Hz OR
> * - All SubVP pipes are >= 120hz
> *
> - * @return: True if admissible, false otherwise
> - *
> - * ************************************************************************************************
> + * Return: True if admissible, false otherwise
> */
> static bool subvp_subvp_admissable(struct dc *dc,
> struct dc_state *context)
Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>
More information about the amd-gfx
mailing list