[PATCH] drm/amdgpu: Add missing function parameter 'optc' & 'enable' to kdoc in optc3_set_timing_double_buffer()

Rodrigo Siqueira Jordao Rodrigo.Siqueira at amd.com
Mon Jun 12 13:23:48 UTC 2023



On 6/3/23 08:53, Srinivasan Shanmugam wrote:
> Fixes the following gcc with W=1:
> 
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_optc.c:285: warning: Function parameter or member 'optc' not described in 'optc3_set_timing_double_buffer'
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_optc.c:285: warning: Function parameter or member 'enable' not described in 'optc3_set_timing_double_buffer'
> 
> Cc: Harry Wentland <harry.wentland at amd.com>
> Cc: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>
> Cc: Aurabindo Pillai <aurabindo.pillai at amd.com>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam at amd.com>
> ---
>   drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.c b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.c
> index c6f5f3df8061..dfb8f62765f2 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.c
> @@ -279,6 +279,9 @@ static void optc3_set_odm_combine(struct timing_generator *optc, int *opp_id, in
>    * Sets double buffer point for V_TOTAL, H_TOTAL, VTOTAL_MIN,
>    * VTOTAL_MAX, VTOTAL_MIN_SEL and VTOTAL_MAX_SEL registers.
>    *
> + * @optc: timing_generator instance.
> + * @enable: Enable DRR double buffering control if true, disable otherwise.
> + *
>    * Options: any time,  start of frame, dp start of frame (range timing)
>    */
>   static void optc3_set_timing_double_buffer(struct timing_generator *optc, bool enable)

Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>


More information about the amd-gfx mailing list