[PATCH] drm/amdkfd: fix null queue check on debug setting exceptions

Felix Kuehling felix.kuehling at amd.com
Mon Jun 12 17:47:37 UTC 2023


Am 2023-06-12 um 11:46 schrieb Jonathan Kim:
> Null check should be done on queue struct itself and not on the
> process queue list node.
>
> Signed-off-by: Jonathan Kim <jonathan.kim at amd.com>

Reviewed-by: Felix Kuehling <Felix.Kuehling at amd.com>


> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_debug.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_debug.c b/drivers/gpu/drm/amd/amdkfd/kfd_debug.c
> index cd34e7aaead4..fff3ccc04fa9 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_debug.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_debug.c
> @@ -1097,7 +1097,7 @@ void kfd_dbg_set_enabled_debug_exception_mask(struct kfd_process *target,
>   
>   	pqm = &target->pqm;
>   	list_for_each_entry(pqn, &pqm->queues, process_queue_list) {
> -		if (!pqn)
> +		if (!pqn->q)
>   			continue;
>   
>   		found_mask |= pqn->q->properties.exception_status;


More information about the amd-gfx mailing list