[PATCH] Revert "drm/amd/display: fix dpms_off issue when disabling bios mode"

[Mike Lothian]

Thanks

I'm happy to help debug this further

On Mon, 12 Jun 2023 at 15:18, Harry Wentland <harry.wentland at amd.com> wrote:
>
> On 6/12/23 10:00, Alex Deucher wrote:
> > This reverts commit 58e67bb3c131da5ee14e4842b08e53f4888dce0a.
> >
> > This patch was reverted, but came back again as
> > commit 58e67bb3c131 ("drm/amd/display: fix dpms_off issue when disabling bios mode")
> > Revert it again as it breaks Asus G513QY / 6800M laptops.
> >
> > Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2259
> > Cc: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>
> > Cc: Zhongwei <Zhongwei.Zhang at amd.com>
> > Cc: Harry Wentland <harry.wentland at amd.com>
> > Cc: Mike Lothian <mike at fireburn.co.uk>
> > Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
>
> Reviewed-by: Harry Wentland <harry.wentland at amd.com>
>
> Harry
>
> > ---
> >  drivers/gpu/drm/amd/display/dc/core/dc.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> > index be72e03cdf92..5d3d61faeb28 100644
> > --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> > +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> > @@ -1296,7 +1296,7 @@ static void disable_vbios_mode_if_required(
> >
> >                                       if (pix_clk_100hz != requested_pix_clk_100hz) {
> >                                               dc->link_srv->set_dpms_off(pipe);
> > -                                             pipe->stream->dpms_off = true;
> > +                                             pipe->stream->dpms_off = false;
> >                                       }
> >                               }
> >                       }
>