[PATCH] drm/amdgpu: enable mcbp by default on gfx9 chips

Christian König ckoenig.leichtzumerken at gmail.com
Fri Jun 16 12:47:11 UTC 2023


Am 16.06.23 um 07:07 schrieb jiadong.zhu at amd.com:
> From: Jiadong Zhu <Jiadong.Zhu at amd.com>
>
> Gfx9 is using software rings which would trigger mcbp in some cases.
> Thus the parameter amdgpu_mcbp shall be enabled by default.

Actually the idea was to not need the amdgpu_mcbp parameter any more and 
deprecate it with the use of the software rings.

Why is that still necessary?

Regards,
Christian.

>
> Signed-off-by: Jiadong Zhu <Jiadong.Zhu at amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> index 65577eca58f1..1b3cfda946f9 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> @@ -4527,6 +4527,7 @@ static int gfx_v9_0_early_init(void *handle)
>   	adev->gfx.xcc_mask = 1;
>   	adev->gfx.num_compute_rings = min(amdgpu_gfx_get_num_kcq(adev),
>   					  AMDGPU_MAX_COMPUTE_RINGS);
> +	amdgpu_mcbp = 1;
>   	gfx_v9_0_set_kiq_pm4_funcs(adev);
>   	gfx_v9_0_set_ring_funcs(adev);
>   	gfx_v9_0_set_irq_funcs(adev);



More information about the amd-gfx mailing list