[PATCH] drm/amd: Don't try to enable secure display TA multiple times

[Alex Deucher]

On Thu, Jun 22, 2023 at 11:19 PM Mario Limonciello
<mario.limonciello at amd.com> wrote:
>
> If the securedisplay TA failed to load the first time, it's unlikely
> to work again after a suspend/resume cycle or reset cycle and it appears
> to be causing problems in futher attempts.
>
> Fixes: e42dfa66d592 ("drm/amdgpu: Add secure display TA load for Renoir")
> Reported-by: Filip Hejsek <filip.hejsek at gmail.com>
> Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/2633
> Signed-off-by: Mario Limonciello <mario.limonciello at amd.com>

Acked-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> index 89a62df76a12..c4cef3f2af3e 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> @@ -1937,6 +1937,8 @@ static int psp_securedisplay_initialize(struct psp_context *psp)
>                 psp_securedisplay_parse_resp_status(psp, securedisplay_cmd->status);
>                 dev_err(psp->adev->dev, "SECUREDISPLAY: query securedisplay TA failed. ret 0x%x\n",
>                         securedisplay_cmd->securedisplay_out_message.query_ta.query_cmd_ret);
> +               /* don't try again */
> +               psp->securedisplay_context.context.bin_desc.size_bytes = 0;
>         }
>
>         return 0;
> --
> 2.34.1
>