[PATCH 1/4] drm/amd/display: Correct `DMUB_FW_VERSION` macro

[Leo Li]

On 6/22/23 14:25, Mario Limonciello wrote:
> The `DMUB_FW_VERSION` macro has a mistake in that the revision field
> is off by one byte. The last byte is typically used for other purposes
> and not a revision.
> 
> Cc: Sean Wang <sean.ns.wang at amd.com>
> Cc: Marc Rossi <Marc.Rossi at amd.com>
> Cc: Hamza Mahfooz <Hamza.Mahfooz at amd.com>
> Cc: Tsung-hua (Ryan) Lin <Tsung-hua.Lin at amd.com>
> Signed-off-by: Mario Limonciello <mario.limonciello at amd.com>

Reviewed-by: Leo Li <sunpeng.li at amd.com>

> ---
>   drivers/gpu/drm/amd/display/dmub/dmub_srv.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dmub/dmub_srv.h b/drivers/gpu/drm/amd/display/dmub/dmub_srv.h
> index 7c9a2b34bd05..2a66a305679a 100644
> --- a/drivers/gpu/drm/amd/display/dmub/dmub_srv.h
> +++ b/drivers/gpu/drm/amd/display/dmub/dmub_srv.h
> @@ -492,7 +492,7 @@ struct dmub_notification {
>    * of a firmware to know if feature or functionality is supported or present.
>    */
>   #define DMUB_FW_VERSION(major, minor, revision) \
> -	((((major) & 0xFF) << 24) | (((minor) & 0xFF) << 16) | ((revision) & 0xFFFF))
> +	((((major) & 0xFF) << 24) | (((minor) & 0xFF) << 16) | (((revision) & 0xFF) << 8))
>   
>   /**
>    * dmub_srv_create() - creates the DMUB service.