[PATCH v2] drm/amd/display: Remove unnecessary casts in amdgpu_dm_helpers.c
Srinivasan Shanmugam
srinivasan.shanmugam at amd.com
Sat Jun 24 05:08:34 UTC 2023
Fixes the following category of checkpatch complaints:
WARNING: unnecessary cast may hide bugs, see http://c-faq.com/malloc/mallocnocast.html
+ char *buf = (char *)kvcalloc(total, sizeof(char), GFP_KERNEL);
Cc: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>
Cc: Aurabindo Pillai <aurabindo.pillai at amd.com>
Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam at amd.com>
---
v2:
- updated commit message
- Initialized char *buf = NULL; in the beginning of the func
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
index cd20cfc04996..dfa3de065182 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
@@ -373,6 +373,7 @@ void dm_dtn_log_append_v(struct dc_context *ctx,
va_list args;
size_t total;
int n;
+ char *buf = NULL;
if (!log_ctx) {
/* No context, redirect to dmesg. */
@@ -400,7 +401,7 @@ void dm_dtn_log_append_v(struct dc_context *ctx,
total = log_ctx->pos + n + 1;
if (total > log_ctx->size) {
- char *buf = (char *)kvcalloc(total, sizeof(char), GFP_KERNEL);
+ buf = kvcalloc(total, sizeof(char), GFP_KERNEL);
if (buf) {
memcpy(buf, log_ctx->buf, log_ctx->pos);
--
2.25.1
More information about the amd-gfx
mailing list