[PATCH] drm/amd: Fix a documentation warning about excess parameters
Limonciello, Mario
mario.limonciello at amd.com
Mon Jun 26 15:13:44 UTC 2023
On 6/26/2023 10:05 AM, Alex Deucher wrote:
> On Mon, Jun 26, 2023 at 11:00 AM Mario Limonciello
> <mario.limonciello at amd.com> wrote:
>> `pcie_index` and `pcie_data` aren't used by
>> amdgpu_device_indirect_wreg() since commit 65ba96e91b68
>> ("drm/amdgpu: Move to common indirect reg access helper") but
>> the documentation wasn't updated. This causes a warning while
>> building documentation.
>>
>> Fixes: 65ba96e91b68 ("drm/amdgpu: Move to common indirect reg access helper")
>> Signed-off-by: Mario Limonciello <mario.limonciello at amd.com>
> Reviewed-by: Alex Deucher <alexander.deucher at amd.com>
It turns out that the exact same patch already landed in ASDN as:
fbdfbe84aaf4 ("drm/amdgpu: Fix up kdoc in amdgpu_device.c")
and I missed this. Sorry for that.
>
>> ---
>> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ----
>> 1 file changed, 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>> index 65fe0f3488679..a3dae8ffbdb10 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>> @@ -747,8 +747,6 @@ u64 amdgpu_device_indirect_rreg64(struct amdgpu_device *adev,
>> * amdgpu_device_indirect_wreg - write an indirect register address
>> *
>> * @adev: amdgpu_device pointer
>> - * @pcie_index: mmio register offset
>> - * @pcie_data: mmio register offset
>> * @reg_addr: indirect register offset
>> * @reg_data: indirect register data
>> *
>> @@ -778,8 +776,6 @@ void amdgpu_device_indirect_wreg(struct amdgpu_device *adev,
>> * amdgpu_device_indirect_wreg64 - write a 64bits indirect register address
>> *
>> * @adev: amdgpu_device pointer
>> - * @pcie_index: mmio register offset
>> - * @pcie_data: mmio register offset
>> * @reg_addr: indirect register offset
>> * @reg_data: indirect register data
>> *
>> --
>> 2.34.1
>>
More information about the amd-gfx
mailing list