[PATCH v3 2/2] drm/probe_helper: warning on poll_enabled for issue catching

[Chen, Guchun]

> -----Original Message-----
> From: Jani Nikula <jani.nikula at linux.intel.com>
> Sent: Friday, March 10, 2023 8:05 PM
> To: Chen, Guchun <Guchun.Chen at amd.com>; amd-
> gfx at lists.freedesktop.org; dri-devel at lists.freedesktop.org; Deucher,
> Alexander <Alexander.Deucher at amd.com>; Zhang, Hawking
> <Hawking.Zhang at amd.com>; dmitry.baryshkov at linaro.org;
> spasswolf at web.de; mike at fireburn.co.uk
> Cc: Chen, Guchun <Guchun.Chen at amd.com>
> Subject: Re: [PATCH v3 2/2] drm/probe_helper: warning on poll_enabled for
> issue catching
> 
> On Fri, 10 Mar 2023, Guchun Chen <guchun.chen at amd.com> wrote:
> > In order to catch issues in other drivers to ensure proper call
> > sequence of polling function.
> >
> > v2: drop Fixes tag in commit message
> >
> > Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2411
> > Reported-by: Bert Karwatzki <spasswolf at web.de>
> > Suggested-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
> > Signed-off-by: Guchun Chen <guchun.chen at amd.com>
> > ---
> >  drivers/gpu/drm/drm_probe_helper.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/drm_probe_helper.c
> > b/drivers/gpu/drm/drm_probe_helper.c
> > index 8127be134c39..85e0e80d4a52 100644
> > --- a/drivers/gpu/drm/drm_probe_helper.c
> > +++ b/drivers/gpu/drm/drm_probe_helper.c
> > @@ -852,6 +852,8 @@
> EXPORT_SYMBOL(drm_kms_helper_is_poll_worker);
> >   */
> >  void drm_kms_helper_poll_disable(struct drm_device *dev)  {
> > +	WARN_ON(!dev->mode_config.poll_enabled);
> 
> Please address all previous review comments [1].

Sorry for missing your previous review email. Will address it in next patch set.

Regards,
Guchun

> BR,
> Jani.
> 
> 
> [1] https://lore.kernel.org/r/87o7p3bde6.fsf@intel.com
> 
> 
> > +
> >  	if (dev->mode_config.poll_running)
> >  		drm_kms_helper_disable_hpd(dev);
> 
> --
> Jani Nikula, Intel Open Source Graphics Center