[PATCH] drm/amd/display: Set MPC_SPLIT_DYNAMIC for DCN301

[Melissa Wen]

On 03/09, Rodrigo Siqueira wrote:
> Since DC version 3.2.226, DC started to use a new internal commit
> sequence that better deals with hardware limitations. Usually, DC adopts
> split pipe dynamics to improve the display bandwidth and, in some cases,
> to save power. This commit sets MPC_SPLIT_DYNAMIC for DCN301, improving
> the bandwidth and fixing the cursor bug on KDE when it tries hardware
> rotation.

Hi Siqueira,

Thanks for the work on allowing this pipe split policy change. I've
tested SteamDeck system behavior with this change and overall LGTM.

From my previous tests on HW rotation, I don't see glitches when
splitting pipe, the issue only appears on one-pipe setup, but Xaver is
the best person to validate this on KDE environment.

Thanks,
Reviewed-by: Melissa Wen <mwen at igalia.com>

> 
> Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2247
> Cc: Melissa Wen <mwen at igalia.com>
> Cc: Xaver Hugl <xaver.hugl at gmail.com>
> Signed-off-by: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>
> ---
>  drivers/gpu/drm/amd/display/dc/dcn301/dcn301_resource.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn301/dcn301_resource.c b/drivers/gpu/drm/amd/display/dc/dcn301/dcn301_resource.c
> index b93b4498dba4..5ac2a272c380 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn301/dcn301_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn301/dcn301_resource.c
> @@ -687,7 +687,7 @@ static const struct dc_debug_options debug_defaults_drv = {
>  	.disable_clock_gate = true,
>  	.disable_pplib_clock_request = true,
>  	.disable_pplib_wm_range = true,
> -	.pipe_split_policy = MPC_SPLIT_AVOID,
> +	.pipe_split_policy = MPC_SPLIT_DYNAMIC,
>  	.force_single_disp_pipe_split = false,
>  	.disable_dcc = DCC_ENABLE,
>  	.vsr_support = true,
> -- 
> 2.39.2
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20230311/261a0eae/attachment.sig>