[PATCH 00/10] drm/radeon: Convert fbdev to DRM client

Christian König christian.koenig at amd.com
Fri Mar 17 08:53:20 UTC 2023


Am 16.03.23 um 10:37 schrieb Thomas Zimmermann:
> Convert radeon's fbdev code to drm_client. Replaces the current
> ad-hoc integration. The conversion includes a number of cleanups.
> Only build fbdev support if the config option has been set.

I'm torn apart on that. On the one hand it looks like a really nice 
cleanup on the other hand we don't really want to touch radeon any more.

Alex what do you think? Is that worth the risk of breaking stuff?

Christian.

>
> Thomas Zimmermann (10):
>    drm/radeon: Move radeon_align_pitch() next to dumb-buffer helpers
>    drm/radeon: Improve fbdev object-test helper
>    drm/radeon: Remove struct radeon_fbdev
>    drm/radeon: Remove test for !screen_base in fbdev probing
>    drm/radeon: Move fbdev object helpers before struct fb_ops et al
>    drm/radeon: Fix coding style in fbdev emulation
>    drm/radeon: Move fbdev cleanup code into fb_destroy callback
>    drm/radeon: Correctly clean up failed display probing
>    drm/radeon: Implement client-based fbdev emulation
>    drm/radeon: Only build fbdev if DRM_FBDEV_EMULATION is set
>
>   drivers/gpu/drm/radeon/Makefile         |   3 +-
>   drivers/gpu/drm/radeon/radeon.h         |   2 +
>   drivers/gpu/drm/radeon/radeon_display.c |   4 -
>   drivers/gpu/drm/radeon/radeon_drv.c     |   3 +-
>   drivers/gpu/drm/radeon/radeon_drv.h     |   1 -
>   drivers/gpu/drm/radeon/radeon_fb.c      | 400 ----------------------
>   drivers/gpu/drm/radeon/radeon_fbdev.c   | 422 ++++++++++++++++++++++++
>   drivers/gpu/drm/radeon/radeon_gem.c     |  24 ++
>   drivers/gpu/drm/radeon/radeon_kms.c     |  18 -
>   drivers/gpu/drm/radeon/radeon_mode.h    |  20 +-
>   10 files changed, 464 insertions(+), 433 deletions(-)
>   delete mode 100644 drivers/gpu/drm/radeon/radeon_fb.c
>   create mode 100644 drivers/gpu/drm/radeon/radeon_fbdev.c
>
>
> base-commit: ec0708e846b819c8d5b642de42448a87d7526564



More information about the amd-gfx mailing list