[PATCH 19/19] drm/amdgpu/smu11: enable TEMP_DEPENDENT_VMIN for navi1x

[Zhuo, Qingqing (Lillian)]

[AMD Official Use Only - General]

Thanks Evan! Will do.

Thanks,
Lillian

-----Original Message-----
From: Quan, Evan <Evan.Quan at amd.com>
Sent: Monday, March 20, 2023 4:26 AM
To: Zhuo, Qingqing (Lillian) <Qingqing.Zhuo at amd.com>; amd-gfx at lists.freedesktop.org
Cc: Wang, Chao-kai (Stylon) <Stylon.Wang at amd.com>; Li, Sun peng (Leo) <Sunpeng.Li at amd.com>; Wentland, Harry <Harry.Wentland at amd.com>; Zhuo, Qingqing (Lillian) <Qingqing.Zhuo at amd.com>; Siqueira, Rodrigo <Rodrigo.Siqueira at amd.com>; Li, Roman <Roman.Li at amd.com>; Chiu, Solomon <Solomon.Chiu at amd.com>; Pillai, Aurabindo <Aurabindo.Pillai at amd.com>; Lin, Wayne <Wayne.Lin at amd.com>; Deucher, Alexander <Alexander.Deucher at amd.com>; Lakha, Bhawanpreet <Bhawanpreet.Lakha at amd.com>; Gutierrez, Agustin <Agustin.Gutierrez at amd.com>; Kotarac, Pavle <Pavle.Kotarac at amd.com>
Subject: RE: [PATCH 19/19] drm/amdgpu/smu11: enable TEMP_DEPENDENT_VMIN for navi1x

[AMD Official Use Only - General]

Better to update the subject with prefix as "drm/amd/pm" to align with other power changes.
Either way the patch is
Reviewed-by: Evan Quan <evan.quan at amd.com>

BR
Evan
> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of
> Qingqing Zhuo
> Sent: Saturday, March 18, 2023 3:56 PM
> To: amd-gfx at lists.freedesktop.org
> Cc: Wang, Chao-kai (Stylon) <Stylon.Wang at amd.com>; Li, Sun peng (Leo)
> <Sunpeng.Li at amd.com>; Wentland, Harry <Harry.Wentland at amd.com>; Zhuo,
> Qingqing (Lillian) <Qingqing.Zhuo at amd.com>; Siqueira, Rodrigo
> <Rodrigo.Siqueira at amd.com>; Li, Roman <Roman.Li at amd.com>; Chiu,
> Solomon <Solomon.Chiu at amd.com>; Pillai, Aurabindo
> <Aurabindo.Pillai at amd.com>; Lin, Wayne <Wayne.Lin at amd.com>; Deucher,
> Alexander <Alexander.Deucher at amd.com>; Lakha, Bhawanpreet
> <Bhawanpreet.Lakha at amd.com>; Gutierrez, Agustin
> <Agustin.Gutierrez at amd.com>; Kotarac, Pavle <Pavle.Kotarac at amd.com>
> Subject: [PATCH 19/19] drm/amdgpu/smu11: enable TEMP_DEPENDENT_VMIN
> for navi1x
>
> From: Alex Deucher <alexander.deucher at amd.com>
>
> May help stability with some navi1x boards.
>
> Hopefully this helps with stability with multiple monitors and would
> allow us to re-enable MPC_SPLIT_DYNAMIC in the DC code for better power savings.
>
> Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2196
>
> Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>
> Acked-by: Qingqing Zhuo <qingqing.zhuo at amd.com>
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
> ---
>  drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c
> b/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c
> index 95da6dd1cc65..c4000518dc56 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c
> @@ -304,7 +304,8 @@ navi10_get_allowed_feature_mask(struct
> smu_context *smu,
>                               | FEATURE_MASK(FEATURE_GFX_SS_BIT)
>                               | FEATURE_MASK(FEATURE_APCC_DFLL_BIT)
>                               | FEATURE_MASK(FEATURE_FW_CTF_BIT)
> -                             |
> FEATURE_MASK(FEATURE_OUT_OF_BAND_MONITOR_BIT);
> +                             |
> FEATURE_MASK(FEATURE_OUT_OF_BAND_MONITOR_BIT)
> +                             |
> FEATURE_MASK(FEATURE_TEMP_DEPENDENT_VMIN_BIT);
>
>       if (adev->pm.pp_feature & PP_SCLK_DPM_MASK)
>               *(uint64_t *)feature_mask |=
> FEATURE_MASK(FEATURE_DPM_GFXCLK_BIT);
> --
> 2.34.1