[PATCH 06/10] drm/amdgpu: don't require a job for cond_exec and shadow

Christian König ckoenig.leichtzumerken at gmail.com
Mon Mar 20 15:50:22 UTC 2023


Am 17.03.23 um 18:17 schrieb Alex Deucher:
> We need to reset the shadow state every time we submit an
> IB and there needs to be a COND_EXEC packet after the
> SET_Q_PREEMPTION_MODE packet for it to work properly, so
> we should emit both of these packets regardless of whether
> there is a job present or not.
>
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>

Reviewed-by: Christian König <christian.koenig at amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c
> index d88964b9407f..cd5b0df44ffb 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c
> @@ -213,10 +213,10 @@ int amdgpu_ib_schedule(struct amdgpu_ring *ring, unsigned num_ibs,
>   
>   	amdgpu_ring_ib_begin(ring);
>   
> -	if (job && ring->funcs->emit_gfx_shadow)
> +	if (ring->funcs->emit_gfx_shadow)
>   		amdgpu_ring_emit_gfx_shadow(ring, job);
>   
> -	if (job && ring->funcs->init_cond_exec)
> +	if (ring->funcs->init_cond_exec)
>   		patch_offset = amdgpu_ring_init_cond_exec(ring);
>   
>   	amdgpu_device_flush_hdp(adev, ring);



More information about the amd-gfx mailing list